Make WGPURenderPassDepthStencilAttachment extensible #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGPURenderPassColorAttachment is already extensible.
|
Actually it's not a gimme that this should be extensible. WGPURenderPassColorAttachment is in an array so it's really annoying to extend otherwise. WGPURenderPassDepthStencilAttachment is optional (behind a pointer) but not in an array. I still think it makes sense to make it extensible though. |
15 tasks
lokokung
approved these changes
Nov 13, 2024
|
Merging tentatively but keeping |
|
Nov 21 meeting:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WGPURenderPassColorAttachment is already extensible, this should be too.
Issue: None, I think @Kangz found this while we were reviewing the header.
(dawn bug https://crbug.com/378514256)