Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Make TimestampWrites structs extensible, move nullability inside #404

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Proposal: Make TimestampWrites structs extensible, move nullability inside #404

merged 2 commits into from
Nov 13, 2024

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Nov 12, 2024 •
edited
Loading

Issue: None, I think @Kangz found this while we were reviewing the header.
(dawn bug https://crbug.com/378514255)

@kainino0x kainino0x added the !discuss Needs discussion (at meeting or online) label Nov 12, 2024
@kainino0x kainino0x requested a review from lokokung November 12, 2024 01:47
@kainino0x kainino0x mentioned this pull request Nov 12, 2024
Closed
15 tasks
@kainino0x
Copy link
Collaborator Author

Merging tentatively, still need brief discussion.

@kainino0x kainino0x enabled auto-merge (squash) November 13, 2024 23:28
@kainino0x kainino0x merged commit 93e0c02 into webgpu-native:main Nov 13, 2024
5 checks passed
@kainino0x kainino0x deleted the timestampwrites branch November 13, 2024 23:30
@kainino0x
Copy link
Collaborator Author

kainino0x commented Nov 23, 2024 •
edited
Loading

Nov 21 meeting:

  • KN: Avoids a pointer. Only reason not to is that we have to migrate people. Worth effort? (Not really, to us.)
  • Leave it behind a pointer, but rename/merge the two identical structs into one (any chains can be validated differently depending on whether it's render or compute)
  • CF: yaml should express this as "optional" if it doesn't

Filed as #430

@kainino0x kainino0x removed the !discuss Needs discussion (at meeting or online) label Nov 23, 2024
This was referenced Nov 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokokung lokokung lokokung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainino0x @lokokung