You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Kangz, @lokokung, and I discussed whether any of our non-extensible structs should be extensible, in particular WGPUStencilFaceState, WGPUBlendState/WGPUBlendComponent, and WGPUVertexBufferLayout/WGPUVertexAttribute.
To guess I looked at vulkan_core.h. Of these:
VkStencilOpState is not extensible (and these can be extended in WGPUDepthStencilState)
VkPipelineColorBlendAttachmentState is not extensible (and these can be extended in WGPUColorTargetState)
VkVertexInputBindingDescription/VkVertexInputAttributeDescription are not extensible BUT VkVertexInputBindingDescription2EXT (adds divisor, merging in VkPipelineVertexInputDivisorStateCreateInfoKHR?)
and VkVertexInputAttributeDescription2EXT (adds no fields) are extensible.
These seem to be used only in vkCmdSetVertexInputEXT, not in any pipeline descriptor, but I guess that means we should make them extensible.
The text was updated successfully, but these errors were encountered:
(Note the parent struct WGPUVertexState IS extensible, but since both WGPUVertexBufferLayout and WGPUVertexAttribute are in arrays, it is not nice to extend them in the parent struct.)
@Kangz, @lokokung, and I discussed whether any of our non-extensible structs should be extensible, in particular
WGPUStencilFaceState
,WGPUBlendState
/WGPUBlendComponent
, andWGPUVertexBufferLayout
/WGPUVertexAttribute
.To guess I looked at
vulkan_core.h
. Of these:VkStencilOpState
is not extensible (and these can be extended inWGPUDepthStencilState
)VkPipelineColorBlendAttachmentState
is not extensible (and these can be extended inWGPUColorTargetState
)VkVertexInputBindingDescription
/VkVertexInputAttributeDescription
are not extensible BUTVkVertexInputBindingDescription2EXT
(addsdivisor
, merging inVkPipelineVertexInputDivisorStateCreateInfoKHR
?)and
VkVertexInputAttributeDescription2EXT
(adds no fields) are extensible.These seem to be used only in
vkCmdSetVertexInputEXT
, not in any pipeline descriptor, but I guess that means we should make them extensible.The text was updated successfully, but these errors were encountered: