Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated columns on Candidate Tests page
alflennik
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Importantly, would you mind changing the url to candidate-review as well?
Less important, but still important, I was wondering if you would be able to rename the components and code which refer to "Candidate Tests" as opposed to Candidate Review. That kind of blows up the size of the PR unfortunately but I think it's worth it just to reduce the amount of mental overhead tracking the "old name" of the feature.
The main feature of the PR, moving the dates to their own columns, worked great for me. Nice.
|
Think I got everything! I renamed every conceptually related use of |
alflennik
approved these changes
Aug 10, 2023
howard-e
approved these changes
Aug 10, 2023
2 tasks
8 tasks
howard-e
pushed a commit
that referenced
this pull request
Aug 15, 2023
…ated columns on Candidate Tests page (#730) * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page * Change page title from Candidate Tests to Candidate Review * Update URL from '/candidate-tests' to `/candidate-review' * Rename relevant variables and components * Rename client/components/CandidateTests/ to client/components/CandidateReview
howard-e
added a commit
that referenced
this pull request
Aug 15, 2023
* initial model, migration, and seeder * seeders test plan ids * test plan service * fixing migration * updating migrations to have foreign keys * Implementing Howard's feedback * Start to migrations and functions to support the DB change for further support of 648 * Update migrations and resolvers to update the individual test plan reports so they can be a part of the same testplanversion going through the candidate phase * Add phase to TestPlanVersion * Update resolver and logic for providing content on the reports page * Update query and resolvers for single report pages * Update query and resolvers for test plan version mutations * Support for CandidateTests functionality and returned other basic functionality which will be removed in the future such as individual test plan report updating * Restored viewing of CandidateTestPlanRun * Fix graphql.schema * Update migrations * Remove unused references * Update tests * Rename TestPlanVersion date fields with 'status' in name to 'phase' * Add approvedAt column to TestPlanReport * Rename candidateStatusReachedAt to approvedAt * Update migration to not use server specific function * Update migration to be more clear and help in functional priority of following migrations * Start draft of new Data Management page * Add links to single-page view of the plans * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value and set the phase to RD if not * Update content of cells * Show remaining data content for the Data Management Row * Update the updatePhaseResolver * Added checks to account for how the phase promotions will be done * Making changes to account for using data from earlier runs when promoting a test plan version * Implementation of preserving data with earlier version of test plan when the runs for a target doesn't exist * Cleanup, comments and refactoring * Sunset earlier test plan version during phase update * Update TestManagement references to DataManagement * Update Test Plan, Covered At and Overall Status columns based on latest mockups * Implemented P0 styling items from latest mockups * Styling updates * Remove old version of test management content * Add proptypes check * Update Data Management page to allow access without being an admin * Hide admin actions on data management page * Adjust column sizes * Update tests * Update condition for when 'Advance to Recommended' button is shown * Restrict condition for phase transition * Editorial changes * Editorial changes * Cleanup TODOs * Address rare error condition * Add confirmation dialog when advancing test plan version; reduce values being requested * Unique test plan report combinations shown in advance confirmation dialog * Update test * Update tests * Update focus points when advancing phases * Update migration to make purpose clearer * Add validation for candidate phase * Set default sorting for data management table * Create /test-review endpoint for displaying what's available at aria-at.netlify in-app * Update Data Management VERSION_STRING link to point to template generated at /test-review * Fix sorting related bug with ManageTestQueue component * Remove required reports logic from updatePhaseResolver; needs to be moved to its own PR * Update test * Stop checks to see if testPlanReports exist which use an AT. Instead, show all currently known ats in this Covered ATs column * Reverse logic for showing the latest versions for a test plan * Re-evaluate sorting logic for DataManagement default phase sorting and applicable Test Plan Versions shown for ManageTestQueue component * Fix issue where latest version not being shown in row * Update mock data * Add note to docs * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page (#730) * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page * Change page title from Candidate Tests to Candidate Review * Update URL from '/candidate-tests' to `/candidate-review' * Rename relevant variables and components * Rename client/components/CandidateTests/ to client/components/CandidateReview * Add version string to candidate tests page (#729) * Start to revised Test Queue page * Do checks for isApproved testPlanReports * Removed 'Mark as ...' and 'Change Target Date' buttons from Candidate Test Plans * Update .status references * Update Sequelize model tests * Update embed.js to check for 'TestPlanVersion.phase' instead of 'TestPlanReport.status' * When setting to DRAFT, set the attached TestPlanReports approvedAt to null (this functionality may not be specified as yet but just in case) * Update Test Queue Run and Candidate Test Run to remove references to testPlanReport.status * Add visual detail when representing candidate phase start and completion dates * Show time to target date on Data Management Row * Added functionality for changing the recommended phase target date on data management page * Make recommended phase target date modal admin specific * Update tests * Update TestPlanReportService.test.js * Update TestPlanVersionService.test.js * Make 'can be finalized' test more predictable * Cleanup * Update migrations to support future migrations when migrating from this as the initial point * Update TestQueue/queries.js to only check for reports which don't have an approvedAt date * Addressing minor feedback comments * Cleanup * Update tests * Add checks when updating a TestPlanVersion phase which has no TestPlanReports which have been marked as final; also check if TestPlanVersions which do not have final reports aren't shown on /reports * Update tests * Re-use hashTests util * Partially address #723 * Address feedback comments * Update markAsFinalResolver.js to check if report can be finalized * Add check for conflicts when marking report as final * Rename approvedAt to markedFinalAt for consistency based on #632 comment * Update test * Add unmarkAsFinalResolver.js * Update CandidateReview after rebase * Resolve #740 * Remove unnecessary console.log * Cleanup files after merge --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]>
howard-e
added a commit
that referenced
this pull request
Aug 15, 2023
* Start draft of new Data Management page * Add links to single-page view of the plans * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value and set the phase to RD if not * Update content of cells * Show remaining data content for the Data Management Row * Update the updatePhaseResolver * Added checks to account for how the phase promotions will be done * Making changes to account for using data from earlier runs when promoting a test plan version * Implementation of preserving data with earlier version of test plan when the runs for a target doesn't exist * Cleanup, comments and refactoring * Sunset earlier test plan version during phase update * Update TestManagement references to DataManagement * Update Test Plan, Covered At and Overall Status columns based on latest mockups * Implemented P0 styling items from latest mockups * Styling updates * Remove old version of test management content * Add proptypes check * Update Data Management page to allow access without being an admin * Hide admin actions on data management page * Adjust column sizes * Update tests * Update condition for when 'Advance to Recommended' button is shown * Restrict condition for phase transition * Editorial changes * Editorial changes * Cleanup TODOs * Add confirmation dialog when advancing test plan version; reduce values being requested * Unique test plan report combinations shown in advance confirmation dialog * Update test * Update tests * Update focus points when advancing phases * Update migration to make purpose clearer * Add validation for candidate phase * Set default sorting for data management table * Create /test-review endpoint for displaying what's available at aria-at.netlify in-app * Update Data Management VERSION_STRING link to point to template generated at /test-review * Fix sorting related bug with ManageTestQueue component * Remove required reports logic from updatePhaseResolver; needs to be moved to its own PR * Update test * Stop checks to see if testPlanReports exist which use an AT. Instead, show all currently known ats in this Covered ATs column * Reverse logic for showing the latest versions for a test plan * Re-evaluate sorting logic for DataManagement default phase sorting and applicable Test Plan Versions shown for ManageTestQueue component * Fix issue where latest version not being shown in row * Update mock data * Add note to docs * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page (#730) * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page * Change page title from Candidate Tests to Candidate Review * Update URL from '/candidate-tests' to `/candidate-review' * Rename relevant variables and components * Rename client/components/CandidateTests/ to client/components/CandidateReview * Add version string to candidate tests page (#729) * Verify that the criteria for advancing the phase for test plans has been met by referencing required reports for a phase (#722) * initial model, migration, and seeder * seeders test plan ids * test plan service * fixing migration * updating migrations to have foreign keys * Implementing Howard's feedback * Start to migrations and functions to support the DB change for further support of 648 * Update migrations and resolvers to update the individual test plan reports so they can be a part of the same testplanversion going through the candidate phase * Add phase to TestPlanVersion * Update resolver and logic for providing content on the reports page * Update query and resolvers for single report pages * Update query and resolvers for test plan version mutations * Support for CandidateTests functionality and returned other basic functionality which will be removed in the future such as individual test plan report updating * Restored viewing of CandidateTestPlanRun * Fix graphql.schema * Update migrations * Remove unused references * Update tests * Rename TestPlanVersion date fields with 'status' in name to 'phase' * Add approvedAt column to TestPlanReport * Rename candidateStatusReachedAt to approvedAt * Update migration to not use server specific function * Update migration to be more clear and help in functional priority of following migrations * Start draft of new Data Management page * Add links to single-page view of the plans * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value and set the phase to RD if not * Update content of cells * Show remaining data content for the Data Management Row * Update the updatePhaseResolver * Added checks to account for how the phase promotions will be done * Making changes to account for using data from earlier runs when promoting a test plan version * Implementation of preserving data with earlier version of test plan when the runs for a target doesn't exist * Cleanup, comments and refactoring * Sunset earlier test plan version during phase update * Update TestManagement references to DataManagement * Update Test Plan, Covered At and Overall Status columns based on latest mockups * Implemented P0 styling items from latest mockups * Styling updates * Remove old version of test management content * Add proptypes check * Update Data Management page to allow access without being an admin * Hide admin actions on data management page * Adjust column sizes * Update tests * Update condition for when 'Advance to Recommended' button is shown * Restrict condition for phase transition * Editorial changes * Editorial changes * Cleanup TODOs * Address rare error condition * Add confirmation dialog when advancing test plan version; reduce values being requested * Unique test plan report combinations shown in advance confirmation dialog * Update test * Update tests * Update focus points when advancing phases * Update migration to make purpose clearer * Add validation for candidate phase * Set default sorting for data management table * Add beginning of validation for Recomended phase * Create /test-review endpoint for displaying what's available at aria-at.netlify in-app * Update Data Management VERSION_STRING link to point to template generated at /test-review * Fix sorting related bug with ManageTestQueue component * Remove required reports logic from updatePhaseResolver; needs to be moved to its own PR * Update test * Stop checks to see if testPlanReports exist which use an AT. Instead, show all currently known ats in this Covered ATs column * Reverse logic for showing the latest versions for a test plan * Re-evaluate sorting logic for DataManagement default phase sorting and applicable Test Plan Versions shown for ManageTestQueue component * Finish verification for recommended phase * Fix failing tests except the datamanagement tests * Add beginning of validation for Recomended phase * Finish verification for recommended phase * Fix failing tests except the datamanagement tests * Update AtBrowsers and everything that has to do with it * Correcting merge conflict lines * Fix updatePhaseResolver * Fix failing tests * Remove comment * Fix function signiture --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Howard Edwards <[email protected]> * Updated Test Queue and Candidate Tests Page (#715) * initial model, migration, and seeder * seeders test plan ids * test plan service * fixing migration * updating migrations to have foreign keys * Implementing Howard's feedback * Start to migrations and functions to support the DB change for further support of 648 * Update migrations and resolvers to update the individual test plan reports so they can be a part of the same testplanversion going through the candidate phase * Add phase to TestPlanVersion * Update resolver and logic for providing content on the reports page * Update query and resolvers for single report pages * Update query and resolvers for test plan version mutations * Support for CandidateTests functionality and returned other basic functionality which will be removed in the future such as individual test plan report updating * Restored viewing of CandidateTestPlanRun * Fix graphql.schema * Update migrations * Remove unused references * Update tests * Rename TestPlanVersion date fields with 'status' in name to 'phase' * Add approvedAt column to TestPlanReport * Rename candidateStatusReachedAt to approvedAt * Update migration to not use server specific function * Update migration to be more clear and help in functional priority of following migrations * Start draft of new Data Management page * Add links to single-page view of the plans * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value and set the phase to RD if not * Update content of cells * Show remaining data content for the Data Management Row * Update the updatePhaseResolver * Added checks to account for how the phase promotions will be done * Making changes to account for using data from earlier runs when promoting a test plan version * Implementation of preserving data with earlier version of test plan when the runs for a target doesn't exist * Cleanup, comments and refactoring * Sunset earlier test plan version during phase update * Update TestManagement references to DataManagement * Update Test Plan, Covered At and Overall Status columns based on latest mockups * Implemented P0 styling items from latest mockups * Styling updates * Remove old version of test management content * Add proptypes check * Update Data Management page to allow access without being an admin * Hide admin actions on data management page * Adjust column sizes * Update tests * Update condition for when 'Advance to Recommended' button is shown * Restrict condition for phase transition * Editorial changes * Editorial changes * Cleanup TODOs * Address rare error condition * Add confirmation dialog when advancing test plan version; reduce values being requested * Unique test plan report combinations shown in advance confirmation dialog * Update test * Update tests * Update focus points when advancing phases * Update migration to make purpose clearer * Add validation for candidate phase * Set default sorting for data management table * Create /test-review endpoint for displaying what's available at aria-at.netlify in-app * Update Data Management VERSION_STRING link to point to template generated at /test-review * Fix sorting related bug with ManageTestQueue component * Remove required reports logic from updatePhaseResolver; needs to be moved to its own PR * Update test * Stop checks to see if testPlanReports exist which use an AT. Instead, show all currently known ats in this Covered ATs column * Reverse logic for showing the latest versions for a test plan * Re-evaluate sorting logic for DataManagement default phase sorting and applicable Test Plan Versions shown for ManageTestQueue component * Fix issue where latest version not being shown in row * Update mock data * Add note to docs * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page (#730) * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page * Change page title from Candidate Tests to Candidate Review * Update URL from '/candidate-tests' to `/candidate-review' * Rename relevant variables and components * Rename client/components/CandidateTests/ to client/components/CandidateReview * Add version string to candidate tests page (#729) * Start to revised Test Queue page * Do checks for isApproved testPlanReports * Removed 'Mark as ...' and 'Change Target Date' buttons from Candidate Test Plans * Update .status references * Update Sequelize model tests * Update embed.js to check for 'TestPlanVersion.phase' instead of 'TestPlanReport.status' * When setting to DRAFT, set the attached TestPlanReports approvedAt to null (this functionality may not be specified as yet but just in case) * Update Test Queue Run and Candidate Test Run to remove references to testPlanReport.status * Add visual detail when representing candidate phase start and completion dates * Show time to target date on Data Management Row * Added functionality for changing the recommended phase target date on data management page * Make recommended phase target date modal admin specific * Update tests * Update TestPlanReportService.test.js * Update TestPlanVersionService.test.js * Make 'can be finalized' test more predictable * Cleanup * Update migrations to support future migrations when migrating from this as the initial point * Update TestQueue/queries.js to only check for reports which don't have an approvedAt date * Addressing minor feedback comments * Cleanup * Update tests * Add checks when updating a TestPlanVersion phase which has no TestPlanReports which have been marked as final; also check if TestPlanVersions which do not have final reports aren't shown on /reports * Update tests * Re-use hashTests util * Partially address #723 * Address feedback comments * Update markAsFinalResolver.js to check if report can be finalized * Add check for conflicts when marking report as final * Rename approvedAt to markedFinalAt for consistency based on #632 comment * Update test * Add unmarkAsFinalResolver.js * Update CandidateReview after rebase * Resolve #740 * Remove unnecessary console.log * Cleanup files after merge --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> --------- Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> Co-authored-by: Erika Miguel <[email protected]>
21 tasks
howard-e
added a commit
that referenced
this pull request
Sep 28, 2023
…abase Implementation to support #648 (#688) Changes added to primarily support #648, but also #518 and w3c/aria-at#950. This includes functional changes to the Data Management, the Test Queue and the Candidate Review pages. It also includes changes to the database structure, described in #632. * feature: updates functionality of Data Management page (#713) * feature: updates functionality of Test Queue page (#715) * feature: updates functionality of Candidate Review page (#715) * feature: include functionality to support the concept of required reports (#722) * feature: adds Test Plan Report Status dialog (#728) * enhancement: move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Review page (#730) * feature: adds Test Plan Version page (#747) * enhancement: explicitly support ‘DEPRECATED’ phase status for TestPlanVersions (#749) * feature: adds filter and sorting functionality by columns headers on Data Management page (#750) * bugfix: update semantic structure of cells with multiple list items on Data Management page (#752) * enhancement: include GitHub issues on Test Plan Version page (#753) * bugfix: revision of the required reports conditions for updating to CANDIDATE and RECOMMENDED phases (#764) * bugfix: removes superfluous header from Test Plan Report Status dialog (#766) * bugfix: update and revise sorts, headings and descriptions of elements on Test Plan Version page (#767) * bugfix: account for several other update phase scenarios that could prevent the update from happening if there is an older TestPlanVersion that exists with results (#771) * bugfix: update headings and revise deprecated dates shown on Test Plan Version page (#773) * enhancement: allow updating of GitHub issues being presented in the app to be more easily understood (#775) * bugfix: correct deprecatedAt date to be relative to when the ‘next’ TestPlanVersion was added (#780) * enhancement: update the text shown when deprecation occurs during a phase on Test Plan Version page (#781) * bugfix: fix inverted sort descriptions and pin sort of of Test Plan name columns on Data Management page (#790) --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> Co-authored-by: Howard Edwards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Note that I did not change the route name in order to preserve any indexing. It is still
/candidate-tests. I can change it if desired.resolves #727