Address edge case scenarios during the updating of TestPlanVersion phase with old TestPlanVersion results #771
Conversation
howard-e
changed the title
…to avoid unexpected errors
…g of old test results
howard-e
force-pushed
the
update-deprecation-process
branch
from
d4eddb7 to
3b9c22c
Compare
There was a problem hiding this comment.
I appreciate this change! And given the complex scenarios at play here, I appreciate the new test suite you added. And the fact you added good sample data that can allow us to easily simulate this deprecation situation is much appreciated as well.
In addition to running the tests successfully I tested the three cases you outlined using the sample data. I also exercised the app a bit using both the sample data and a recent database clone. It all worked for me, which is awesome.
I read through the code. Looks good, not sure I have any changes I'd want to make.
One documentation change which helped me test was to duplicate the sample data that's being used in test environments into the dev environments. I pushed a commit for the database.md file with that change. Let me know if you foresee any issues with that change.
Nice job!
Thanks for checking it out!
@alflennik yep that change looks good to me, thanks for catching that! Noticed a code block formatting being slightly off, so I've fixed that as well. |
…abase Implementation to support #648 (#688) Changes added to primarily support #648, but also #518 and w3c/aria-at#950. This includes functional changes to the Data Management, the Test Queue and the Candidate Review pages. It also includes changes to the database structure, described in #632. * feature: updates functionality of Data Management page (#713) * feature: updates functionality of Test Queue page (#715) * feature: updates functionality of Candidate Review page (#715) * feature: include functionality to support the concept of required reports (#722) * feature: adds Test Plan Report Status dialog (#728) * enhancement: move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Review page (#730) * feature: adds Test Plan Version page (#747) * enhancement: explicitly support ‘DEPRECATED’ phase status for TestPlanVersions (#749) * feature: adds filter and sorting functionality by columns headers on Data Management page (#750) * bugfix: update semantic structure of cells with multiple list items on Data Management page (#752) * enhancement: include GitHub issues on Test Plan Version page (#753) * bugfix: revision of the required reports conditions for updating to CANDIDATE and RECOMMENDED phases (#764) * bugfix: removes superfluous header from Test Plan Report Status dialog (#766) * bugfix: update and revise sorts, headings and descriptions of elements on Test Plan Version page (#767) * bugfix: account for several other update phase scenarios that could prevent the update from happening if there is an older TestPlanVersion that exists with results (#771) * bugfix: update headings and revise deprecated dates shown on Test Plan Version page (#773) * enhancement: allow updating of GitHub issues being presented in the app to be more easily understood (#775) * bugfix: correct deprecatedAt date to be relative to when the ‘next’ TestPlanVersion was added (#780) * enhancement: update the text shown when deprecation occurs during a phase on Test Plan Version page (#781) * bugfix: fix inverted sort descriptions and pin sort of of Test Plan name columns on Data Management page (#790) --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> Co-authored-by: Howard Edwards <[email protected]>
This PR addresses some edge cases found during the update phase process when using old results from an existing TestPlanVersion.
Some likely scenarios being tested: