-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Missing Test Plan Status Management Functions #648
Comments
There is some missing content in the top comment that describes this issue. I am working on it and will update the top comment as I finish each section. |
@jscholes @jugglinmike @ccanash @lolaodelola @isaacdurazo I've now completed documentation in the top comment. Since Thursday, in addition to completing the missing sections, I have made a number of other changes to either simplify or clarify the requirements. I realize that this could be a visually wide table with seven columns. I feel pretty strongly that all 7 columns are necessary and that it is best to avoid combining columns. I've found the column combining we have in other places, like candidate page, to be very problematic as a screen reader user. It also gets in the way of sortability. If table width is a problem, then let's have an ideation session to specifically address the issue. I have a few ideas on how to visually abbreviate, but I'm also concerned about clarity. It might be feasible to combine name and overall status without too severely hurting readability for SR users and preserving the ability to sort by either, but it would add complexity. So, I hope we can make it all fit without doing any of that. BTW, for the test plan versions, we probably don't need the full version string with timestamp; date is probably sufficient in the context of this table. The downside is that it would create inconsistency with how test plan version is displayed elsewhere, so again, probably best to avoid that truncation if we can. |
@lolaodelola @ccanash @jugglinmike I am fairly confident that the P0 and P1 requirements in this proposal will cover close to all if not all MVP gaps we will end up identifying in the working mode scenario analysis. I am anxious to complete the analysis and test this hypothesis. I believe there are some distinct sets of requirements that could be made into issues that could be added to the MVP project and put into the sprint plan. One approach to grouping requirements into specific deliverables might be to create issues for each of the following:
I don't know if the above approach for segmenting work is useful. I suggest it because I think it might be a good way to prioritize work to deliver the most needed functions first. However, there may be sound technical reasons for using a different approach to dividing deliverables across sprints. |
I just had a chance to review this, and I do think the table would be too wide. Since it's not tabular data, maybe we should use a different UI idiom (e.g. a card for each test plan)? What do you think @isaacdurazo? |
@lolaodelola @ccanash @jscholes I edited the top comment to:
I will next work on a mock up of the table data. |
@ccanash wrote:
Both:
|
Visual MockupHere are the visual details for each column from the mockups and styling proposed for the Status Summary Table on the Data Management page. Test Plan ColumnTest plan names are in bold Covered AT columnAll strings are in plain text Overall Status column
R&D Version, Draft Review, Candidate Review, and Recommended Versions columns
|
This is an updated mockup with P1 features for the Status Summary Table on the Data Management page. Here is this summary of updates for each column:
|
Here is a mockup that includes filtering and sorting Text-based MockupFilterThis mockup includes a Filter button at the top right of the Test Plans Status Summary table, in the same row we have the “Test Plans Status Summary” heading. Clicking this button will display a dropdown menu with all the filtering options. This menu uses checkmarks for selecting filters, which means multiple filters can be selected at once, except for the “All Plans” filter. When the filter is active but closed, the filter label will display a number with the number of filters selected. SortingThere are three sortable columns: Test Plan, Covered AT, and Overall Status. Sortable columns will display a pointing down arrow icon on hover. If the column is in its default order, when clicked, it will display a dropdown menu with two sorting options: Ascending and Descending. If one of the sort options is already selected, the items in the drop-down menu are: Clear Sort and Reverse Sort Order When a column has been sorted by any of the two options, the corresponding icon will be persistent next to the column heading. Clicking this icon is another way of reversing the sort other in addition to doing it from the dropdown menu Visual Mockup |
@isaacdurazo wrote:
I have to apologize because One thing I neglected to include in the original proposal is that I saw the filters as serving two separate and distinct but equally important functions. Certainly one use case is filtering. But another that is just as important is to have a persistent at--a-glance view of our most important top-line numbers related to test plan development and management. That is, to summarize the state of the project with the number of patterns with plans, how many of them have an active R&D version, how many have a version in draft review, how many have a version in candidate review, and how many have a recommended version. Providing that top-line summary of the status of ARIA-AT is the reason I suggested a design with separate filter buttons for each phase. I should have said so explicitly. Putting those numbers in a popup menu does not make them visible enough. I don't know that the use case of choosing multiple filters within this set is particularly important. However, it could still be done with a multi-button approach. In that case, the buttons are independent toggles, except for the All button. If they work that way, then it would also be necessary to add a separate message that says how many rows are displayed.
Please provide a persistent icon that indicates sortability. We run into keyboard and cognitive accessibility problems if it is necessary to hover to know that a column is sortable. If you have a persistent icon on all sortable columns, you may be able to avoid the need for a popup menu. If a column is not sorted, you could make the first click do ascending and the second click do descending. Since this is a small table, I am assuming that latency of sort is low, so the downside of performing an unnecessary sort if the user wants descending would not be an issue. Users would end up performing the same number of clicks, and we could avoid the complexity of the menu, which would be very desirable for screen reader users. |
Thanks for clarifying @mcking65 Here is an updated mockup and its description. Filter I'm incorporating a multi-button approach. Between the "Test Plans Status Summary" heading and the table summary, there's a row that starts with the word "Filter" followed by a button for each of the phases. Each one of them includes the number of rows within parenthesis. I think we can start by having the ability to only choose one a at a time since we are not sure about a use case for selecting multiple ones. Sorting All three sortable columns have now a persistent icon. This icon has three states: inactive, active ascending and active descending. By default, the Overall Status column will have the ascending state (icon) active, which uses the order you suggested. R&D at the top first and Recommended at the bottom end. This new approach removes the option to "remove the sorting", so there will a column that's sorted in some way. Please let me know what you think and if this updates reflect your vision. |
…abase Implementation to support #648 (#688) Changes added to primarily support #648, but also #518 and w3c/aria-at#950. This includes functional changes to the Data Management, the Test Queue and the Candidate Review pages. It also includes changes to the database structure, described in #632. * feature: updates functionality of Data Management page (#713) * feature: updates functionality of Test Queue page (#715) * feature: updates functionality of Candidate Review page (#715) * feature: include functionality to support the concept of required reports (#722) * feature: adds Test Plan Report Status dialog (#728) * enhancement: move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Review page (#730) * feature: adds Test Plan Version page (#747) * enhancement: explicitly support ‘DEPRECATED’ phase status for TestPlanVersions (#749) * feature: adds filter and sorting functionality by columns headers on Data Management page (#750) * bugfix: update semantic structure of cells with multiple list items on Data Management page (#752) * enhancement: include GitHub issues on Test Plan Version page (#753) * bugfix: revision of the required reports conditions for updating to CANDIDATE and RECOMMENDED phases (#764) * bugfix: removes superfluous header from Test Plan Report Status dialog (#766) * bugfix: update and revise sorts, headings and descriptions of elements on Test Plan Version page (#767) * bugfix: account for several other update phase scenarios that could prevent the update from happening if there is an older TestPlanVersion that exists with results (#771) * bugfix: update headings and revise deprecated dates shown on Test Plan Version page (#773) * enhancement: allow updating of GitHub issues being presented in the app to be more easily understood (#775) * bugfix: correct deprecatedAt date to be relative to when the ‘next’ TestPlanVersion was added (#780) * enhancement: update the text shown when deprecation occurs during a phase on Test Plan Version page (#781) * bugfix: fix inverted sort descriptions and pin sort of of Test Plan name columns on Data Management page (#790) --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> Co-authored-by: Howard Edwards <[email protected]>
Designs have been approved. Closing |
Related to #518.
UPDATED JUNE 14
June 14 revision summary
Test Plan Status Table Proposal Overview
This issue describes a proposal for the test plan status summary table, including:
It also introduces a new concept of "required reports" to help manage progress of a test plan through the working mode process.
Development priorities
Each feature of the table is marked with a priority of P0, P1, or P2.
The assumption is that we will develop a short list of features in each sprint, with the first several sprints each delivering a set of P0 requirements and later sprints focused on P1 and P2 requirements.
Overview of Columns for Test Plan Status Summary Table
General Description of Phase Columns
Note: As described in w3c/aria-at#950, a test plan may have up to one version in each phase of the working mode. For example, there may be a recommended version and a new version that is ready for draft review at the same time.
The Hhigh-level objectives of the columns for the R&D, Draft, Candidate, and Recommended phases is to enable users to monitor progress of a test plan through the working mode and enable admins to manage the process.
While the content of each column is different, the common objectives are to show:
As described in the detailed descriptions of column content that follows, each phase column may thus have:
Test Plan Column Details
Covered AT Column Details
Overall Status Column Details
P0 Requirement: Show the most advanced phase this plan has completed using the following logic:
Notes:
R&D Version Column Details
Draft Review Column Details
Candidate Review Column Details
Recommended Version Column Details
Default Table Sort
Why?
Links to single-page view of test plan
Note that we will format version identifiers as "Vyy.mm.dd" where yy.mm.dd represent the date of the commit that landed changes to the plan.
This view of the alert plan is provided as an example of a single-page view of a plan. Note that:
Confirmation prompts for advancing a version from one phase to next
P0 Requirement: When a button is activated for advancing a test plan version to the next phase, a confirmation prompt is provided. The prompt must include the name of the test plan, its version, the covered AT, and the name of the new phase.
required Reports Definition
To provide a brief, easy to understand reporting status that facilitates the job of shepherding a specific version of a test plan through the working mode process, this design proposal introduces the concept of required reports. A version of a test plan will be required to have reports for specific AT/browser pairs depending on the working mode phase of the test plan version and the set of AT covered by the plan. If a required report has not been completed or is not in progress, the system will show it as "missing".
The draft and recommended phases will each require reports using a specific set of AT/browser pairs. At this time, the pairings for which reporting is required are as follows.
When we have sufficient testing capacity, the next change will be adding recommended phase reporting requirements for Edge on Windows.
For each AT, the system will need to map valid AT/browser pairings as shown in the above table. Thus, it will not expect a plan that includes VoiceOver for iOS to generate a report on VoiceOver for iOS with Safari for macOS. Similarly it would not expect a plan that includes JAWS to generate a report on Jaws with Safari.
A report for a specific AT/browser pairing will be classified as "missing" if it meets any of the folowing conditions.
Note that in draft phase it is up to the admin to decide whether the AT and browser versions are sufficiently recent. This is because it can be difficult to ensure that all people running manyual tests are running the same versions, and the latest versions are not always necessary for candidate review. However, for recommended reports, the objective is for the system to help us keep reports current using latest versions. For reports on recommended plan versions, either the admin will need to seek people who have the necessary versions or the automation system will need to provide the report.
Test plan report status dialog Description
This dialog shows detailed status of AT/browser reports for a single version of a single test plan.
The label on the button that opens the dialog provides information about the current report status for the test plan. The button has one of the following labels.
The dialog title is: "Report Status for TEST_PLAN_NAME Test Plan"
The dialog content includes a note and a table.
The table columns are:
The table is sorted by required Yes, then required No, then AT, then browser.
The rows that appear in the table are determined as follows.
Filters
Adding a set of quick filter buttons above the table is a P2 requirement. the label on Each filter will show the filter name and number of table rows it will render.
The filter buttons are:
Note: Because each plan may have multiple versions moving through the process, i.e., a version active in more than one phase at the same time, the set of rows shown by each filter is not unique. Thus, if the label on the all plans button were "All Plans 65", the sum of the numbers shown in the labels of the other buttons will likely be greater than 65.
The text was updated successfully, but these errors were encountered: