Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required reports data #758

Closed
mcking65 opened this issue Aug 30, 2023 · 5 comments · Fixed by #764
Closed

Fix required reports data #758

mcking65 opened this issue Aug 30, 2023 · 5 comments · Fixed by #764
Assignees
Labels
bug Something isn't working

Comments

@mcking65
Copy link

The report status dialogs are showing 6 reports required during candidate review. Only 3 are required for draft and candidate:

  1. jaws/chrome

  2. NVDA/Chrome

  3. VoiceOver/Safari
    3 more are required in recommended phase:

  4. JAWS/Firefox

  5. NVDA/Firefox

  6. VoiceOver/Chrome

@howard-e
Copy link
Contributor

This must have been a misunderstanding for the condition when updating to Recommended.

  1. The thought was those additional 3 were required BEFORE being able to transition to Recommended.
  2. That means the Required Reports button should also be available on the Recommended Version cell and it will most likely say Some Required Reports Missing, when initially transitioned to.

@mcking65 if 1 was a false assumption and 2 is the expectation, then #764 addresses this. Could you confirm?

@mcking65
Copy link
Author

This must have been a misunderstanding for the condition when updating to Recommended.

  1. The thought was those additional 3 were required BEFORE being able to transition to Recommended.

No, we can advance to recommended without them.

  1. That means the Required Reports button should also be available on the Recommended Version cell and it will most likely say Some Required Reports Missing, when initially transitioned to.

Definitely, that is the expectation. There are other conditions where it will appear in the recommended phase column. There is a to-do in issue #648 for me to work with you on the algorithm for that.

@mcking65 if 1 was a false assumption and 2 is the expectation, then #764 addresses this. Could you confirm?

Confirmed.

@howard-e
Copy link
Contributor

@mcking65 if 1 was a false assumption and 2 is the expectation, then #764 addresses this. Could you confirm?

Confirmed.

Thanks! #764 has been added to the sandbox and staging environments

@mcking65
Copy link
Author

mcking65 commented Sep 25, 2023

Confirmed that the issue is resolved in staging, at least for draft and candidate test plans. For recommended test plans, the data is correct. However, recommended test plan report status will not be complete until we resolve #792 and #791.

@ccanash
Copy link
Contributor

ccanash commented Oct 3, 2023

released. #792 and #791 will be tackled separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants