Updated Data Management Page (#713)

* Start draft of new Data Management page * Add links to single-page view of the plans * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value and set the phase to RD if not * Update content of cells * Show remaining data content for the Data Management Row * Update the updatePhaseResolver * Added checks to account for how the phase promotions will be done * Making changes to account for using data from earlier runs when promoting a test plan version * Implementation of preserving data with earlier version of test plan when the runs for a target doesn't exist * Cleanup, comments and refactoring * Sunset earlier test plan version during phase update * Update TestManagement references to DataManagement * Update Test Plan, Covered At and Overall Status columns based on latest mockups * Implemented P0 styling items from latest mockups * Styling updates * Remove old version of test management content * Add proptypes check * Update Data Management page to allow access without being an admin * Hide admin actions on data management page * Adjust column sizes * Update tests * Update condition for when 'Advance to Recommended' button is shown * Restrict condition for phase transition * Editorial changes * Editorial changes * Cleanup TODOs * Add confirmation dialog when advancing test plan version; reduce values being requested * Unique test plan report combinations shown in advance confirmation dialog * Update test * Update tests * Update focus points when advancing phases * Update migration to make purpose clearer * Add validation for candidate phase * Set default sorting for data management table * Create /test-review endpoint for displaying what's available at aria-at.netlify in-app * Update Data Management VERSION_STRING link to point to template generated at /test-review * Fix sorting related bug with ManageTestQueue component * Remove required reports logic from updatePhaseResolver; needs to be moved to its own PR * Update test * Stop checks to see if testPlanReports exist which use an AT. Instead, show all currently known ats in this Covered ATs column * Reverse logic for showing the latest versions for a test plan * Re-evaluate sorting logic for DataManagement default phase sorting and applicable Test Plan Versions shown for ManageTestQueue component * Fix issue where latest version not being shown in row * Update mock data * Add note to docs * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page (#730) * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page * Change page title from Candidate Tests to Candidate Review * Update URL from '/candidate-tests' to `/candidate-review' * Rename relevant variables and components * Rename client/components/CandidateTests/ to client/components/CandidateReview * Add version string to candidate tests page (#729) * Verify that the criteria for advancing the phase for test plans has been met by referencing required reports for a phase (#722) * initial model, migration, and seeder * seeders test plan ids * test plan service * fixing migration * updating migrations to have foreign keys * Implementing Howard's feedback * Start to migrations and functions to support the DB change for further support of 648 * Update migrations and resolvers to update the individual test plan reports so they can be a part of the same testplanversion going through the candidate phase * Add phase to TestPlanVersion * Update resolver and logic for providing content on the reports page * Update query and resolvers for single report pages * Update query and resolvers for test plan version mutations * Support for CandidateTests functionality and returned other basic functionality which will be removed in the future such as individual test plan report updating * Restored viewing of CandidateTestPlanRun * Fix graphql.schema * Update migrations * Remove unused references * Update tests * Rename TestPlanVersion date fields with 'status' in name to 'phase' * Add approvedAt column to TestPlanReport * Rename candidateStatusReachedAt to approvedAt * Update migration to not use server specific function * Update migration to be more clear and help in functional priority of following migrations * Start draft of new Data Management page * Add links to single-page view of the plans * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value and set the phase to RD if not * Update content of cells * Show remaining data content for the Data Management Row * Update the updatePhaseResolver * Added checks to account for how the phase promotions will be done * Making changes to account for using data from earlier runs when promoting a test plan version * Implementation of preserving data with earlier version of test plan when the runs for a target doesn't exist * Cleanup, comments and refactoring * Sunset earlier test plan version during phase update * Update TestManagement references to DataManagement * Update Test Plan, Covered At and Overall Status columns based on latest mockups * Implemented P0 styling items from latest mockups * Styling updates * Remove old version of test management content * Add proptypes check * Update Data Management page to allow access without being an admin * Hide admin actions on data management page * Adjust column sizes * Update tests * Update condition for when 'Advance to Recommended' button is shown * Restrict condition for phase transition * Editorial changes * Editorial changes * Cleanup TODOs * Address rare error condition * Add confirmation dialog when advancing test plan version; reduce values being requested * Unique test plan report combinations shown in advance confirmation dialog * Update test * Update tests * Update focus points when advancing phases * Update migration to make purpose clearer * Add validation for candidate phase * Set default sorting for data management table * Add beginning of validation for Recomended phase * Create /test-review endpoint for displaying what's available at aria-at.netlify in-app * Update Data Management VERSION_STRING link to point to template generated at /test-review * Fix sorting related bug with ManageTestQueue component * Remove required reports logic from updatePhaseResolver; needs to be moved to its own PR * Update test * Stop checks to see if testPlanReports exist which use an AT. Instead, show all currently known ats in this Covered ATs column * Reverse logic for showing the latest versions for a test plan * Re-evaluate sorting logic for DataManagement default phase sorting and applicable Test Plan Versions shown for ManageTestQueue component * Finish verification for recommended phase * Fix failing tests except the datamanagement tests * Add beginning of validation for Recomended phase * Finish verification for recommended phase * Fix failing tests except the datamanagement tests * Update AtBrowsers and everything that has to do with it * Correcting merge conflict lines * Fix updatePhaseResolver * Fix failing tests * Remove comment * Fix function signiture --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Howard Edwards <[email protected]> * Updated Test Queue and Candidate Tests Page (#715) * initial model, migration, and seeder * seeders test plan ids * test plan service * fixing migration * updating migrations to have foreign keys * Implementing Howard's feedback * Start to migrations and functions to support the DB change for further support of 648 * Update migrations and resolvers to update the individual test plan reports so they can be a part of the same testplanversion going through the candidate phase * Add phase to TestPlanVersion * Update resolver and logic for providing content on the reports page * Update query and resolvers for single report pages * Update query and resolvers for test plan version mutations * Support for CandidateTests functionality and returned other basic functionality which will be removed in the future such as individual test plan report updating * Restored viewing of CandidateTestPlanRun * Fix graphql.schema * Update migrations * Remove unused references * Update tests * Rename TestPlanVersion date fields with 'status' in name to 'phase' * Add approvedAt column to TestPlanReport * Rename candidateStatusReachedAt to approvedAt * Update migration to not use server specific function * Update migration to be more clear and help in functional priority of following migrations * Start draft of new Data Management page * Add links to single-page view of the plans * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value * Update migration to prevent testPlanVersions not in the DRAFT phase having a draftPhaseReachedAt value and set the phase to RD if not * Update content of cells * Show remaining data content for the Data Management Row * Update the updatePhaseResolver * Added checks to account for how the phase promotions will be done * Making changes to account for using data from earlier runs when promoting a test plan version * Implementation of preserving data with earlier version of test plan when the runs for a target doesn't exist * Cleanup, comments and refactoring * Sunset earlier test plan version during phase update * Update TestManagement references to DataManagement * Update Test Plan, Covered At and Overall Status columns based on latest mockups * Implemented P0 styling items from latest mockups * Styling updates * Remove old version of test management content * Add proptypes check * Update Data Management page to allow access without being an admin * Hide admin actions on data management page * Adjust column sizes * Update tests * Update condition for when 'Advance to Recommended' button is shown * Restrict condition for phase transition * Editorial changes * Editorial changes * Cleanup TODOs * Address rare error condition * Add confirmation dialog when advancing test plan version; reduce values being requested * Unique test plan report combinations shown in advance confirmation dialog * Update test * Update tests * Update focus points when advancing phases * Update migration to make purpose clearer * Add validation for candidate phase * Set default sorting for data management table * Create /test-review endpoint for displaying what's available at aria-at.netlify in-app * Update Data Management VERSION_STRING link to point to template generated at /test-review * Fix sorting related bug with ManageTestQueue component * Remove required reports logic from updatePhaseResolver; needs to be moved to its own PR * Update test * Stop checks to see if testPlanReports exist which use an AT. Instead, show all currently known ats in this Covered ATs column * Reverse logic for showing the latest versions for a test plan * Re-evaluate sorting logic for DataManagement default phase sorting and applicable Test Plan Versions shown for ManageTestQueue component * Fix issue where latest version not being shown in row * Update mock data * Add note to docs * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page (#730) * Move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Tests page * Change page title from Candidate Tests to Candidate Review * Update URL from '/candidate-tests' to `/candidate-review' * Rename relevant variables and components * Rename client/components/CandidateTests/ to client/components/CandidateReview * Add version string to candidate tests page (#729) * Start to revised Test Queue page * Do checks for isApproved testPlanReports * Removed 'Mark as ...' and 'Change Target Date' buttons from Candidate Test Plans * Update .status references * Update Sequelize model tests * Update embed.js to check for 'TestPlanVersion.phase' instead of 'TestPlanReport.status' * When setting to DRAFT, set the attached TestPlanReports approvedAt to null (this functionality may not be specified as yet but just in case) * Update Test Queue Run and Candidate Test Run to remove references to testPlanReport.status * Add visual detail when representing candidate phase start and completion dates * Show time to target date on Data Management Row * Added functionality for changing the recommended phase target date on data management page * Make recommended phase target date modal admin specific * Update tests * Update TestPlanReportService.test.js * Update TestPlanVersionService.test.js * Make 'can be finalized' test more predictable * Cleanup * Update migrations to support future migrations when migrating from this as the initial point * Update TestQueue/queries.js to only check for reports which don't have an approvedAt date * Addressing minor feedback comments * Cleanup * Update tests * Add checks when updating a TestPlanVersion phase which has no TestPlanReports which have been marked as final; also check if TestPlanVersions which do not have final reports aren't shown on /reports * Update tests * Re-use hashTests util * Partially address #723 * Address feedback comments * Update markAsFinalResolver.js to check if report can be finalized * Add check for conflicts when marking report as final * Rename approvedAt to markedFinalAt for consistency based on #632 comment * Update test * Add unmarkAsFinalResolver.js * Update CandidateReview after rebase * Resolve #740 * Remove unnecessary console.log * Cleanup files after merge --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> --------- Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> Co-authored-by: Erika Miguel <[email protected]>
w3c · Aug 15, 2023 · 9043424 · 9043424
1 parent f9ebcc0
commit 9043424
Show file tree

Hide file tree

Showing 104 changed files with 5,150 additions and 2,487 deletions.
diff --git a/client/components/App/App.jsx b/client/components/App/App.jsx
@@ -70,20 +70,17 @@ const App = () => {
                                     Test Reports
                                 </Nav.Link>
                             </li>
-                            {isSignedIn && isAdmin && (
-                                <li>
-                                    <Nav.Link
-                                        as={Link}
-                                        to="/test-management"
-                                        aria-current={
-                                            location.pathname ===
-                                            '/test-management'
-                                        }
-                                    >
-                                        Test Management
-                                    </Nav.Link>
-                                </li>
-                            )}
+                            <li>
+                                <Nav.Link
+                                    as={Link}
+                                    to="/data-management"
+                                    aria-current={
+                                        location.pathname === '/data-management'
+                                    }
+                                >
+                                    Data Management
+                                </Nav.Link>
+                            </li>
                             <li>
                                 <Nav.Link
                                     as={Link}
@@ -105,12 +102,12 @@ const App = () => {
                                 <li>
                                     <Nav.Link
                                         as={Link}
-                                        to="/candidate-tests"
+                                        to="/candidate-review"
                                         aria-current={location.pathname.startsWith(
-                                            '/candidate-test'
+                                            '/candidate'
                                         )}
                                     >
-                                        Candidate Tests
+                                        Candidate Review
                                     </Nav.Link>
                                 </li>
                             )}

diff --git a/...ideFeedbackModal/ProvideFeedbackModal.css → ...ideFeedbackModal/ProvideFeedbackModal.css b/...ideFeedbackModal/ProvideFeedbackModal.css → ...ideFeedbackModal/ProvideFeedbackModal.css
diff --git a/...dateModals/ProvideFeedbackModal/index.jsx → ...dateModals/ProvideFeedbackModal/index.jsx b/...dateModals/ProvideFeedbackModal/index.jsx → ...dateModals/ProvideFeedbackModal/index.jsx
diff --git a/...ateModals/ThankYouModal/ThankYouModal.css → ...ateModals/ThankYouModal/ThankYouModal.css b/...ateModals/ThankYouModal/ThankYouModal.css → ...ateModals/ThankYouModal/ThankYouModal.css
diff --git a/...s/CandidateModals/ThankYouModal/index.jsx → ...w/CandidateModals/ThankYouModal/index.jsx b/...s/CandidateModals/ThankYouModal/index.jsx → ...w/CandidateModals/ThankYouModal/index.jsx
diff --git a/...CandidateTests/CandidateModals/common.css → ...andidateReview/CandidateModals/common.css b/...CandidateTests/CandidateModals/common.css → ...andidateReview/CandidateModals/common.css
diff --git a/...idateTestPlanRun/CandidateTestPlanRun.css → ...idateTestPlanRun/CandidateTestPlanRun.css b/...idateTestPlanRun/CandidateTestPlanRun.css → ...idateTestPlanRun/CandidateTestPlanRun.css
diff --git a/...idateTestPlanRun/InstructionsRenderer.jsx → ...idateTestPlanRun/InstructionsRenderer.jsx b/...idateTestPlanRun/InstructionsRenderer.jsx → ...idateTestPlanRun/InstructionsRenderer.jsx
diff --git a/...idateTests/CandidateTestPlanRun/index.jsx → ...dateReview/CandidateTestPlanRun/index.jsx b/...idateTests/CandidateTestPlanRun/index.jsx → ...dateReview/CandidateTestPlanRun/index.jsx
@@ -724,7 +724,7 @@ const CandidateTestPlanRun = () => {
                     show={true}
                     handleAction={async () => {
                         setThankYouModalShowing(false);
-                        navigate('/candidate-tests');
+                        navigate('/candidate-review');
                     }}
                     githubUrl={generateGithubUrl(
                         false,

diff --git a/...dateTests/CandidateTestPlanRun/queries.js → ...ateReview/CandidateTestPlanRun/queries.js b/...dateTests/CandidateTestPlanRun/queries.js → ...ateReview/CandidateTestPlanRun/queries.js
@@ -37,7 +37,7 @@ export const CANDIDATE_REPORTS_QUERY = gql`
         }
         testPlanReports(
             atId: $atId
-            statuses: [CANDIDATE]
+            testPlanVersionPhases: [CANDIDATE]
             testPlanVersionId: $testPlanVersionId
             testPlanVersionIds: $testPlanVersionIds
         ) {
@@ -65,6 +65,7 @@ export const CANDIDATE_REPORTS_QUERY = gql`
             testPlanVersion {
                 id
                 title
+                phase
                 gitSha
                 testPlan {
                     directory
@@ -142,7 +143,6 @@ export const CANDIDATE_REPORTS_QUERY = gql`
                 }
                 testPlanReport {
                     id
-                    status
                 }
                 testResults {
                     test {

diff --git a/...sts/FeedbackListItem/FeedbackListItem.css → ...iew/FeedbackListItem/FeedbackListItem.css b/...sts/FeedbackListItem/FeedbackListItem.css → ...iew/FeedbackListItem/FeedbackListItem.css
diff --git a/...CandidateTests/FeedbackListItem/index.jsx → ...andidateReview/FeedbackListItem/index.jsx b/...CandidateTests/FeedbackListItem/index.jsx → ...andidateReview/FeedbackListItem/index.jsx
diff --git a/...ts/CandidateTests/TestPlans/TestPlans.css → ...s/CandidateReview/TestPlans/TestPlans.css b/...ts/CandidateTests/TestPlans/TestPlans.css → ...s/CandidateReview/TestPlans/TestPlans.css