Allow arrays to be specified as values in location_cfg_* parameters #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 - this would be very useful. |
|
👍 I applied this patch (manually) to my version of the module and it works great. I don't know if it still supports non-array versions (ie, is it backward compatible?), but this solved my problem of specifying multiple rewrite commands. Thanks. |
|
Can you rebase? I'll get this merged in. |
Allow arrays to be specified as values in location_cfg_{prepend,append} and
vhost_cfg_{ssl_,}{prepend,append} parameters.
yes. Calling All rebased, test cases added and a few more missing key value pairs to array compatible now. |
This was referenced Mar 7, 2014
|
all in #266 - use that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by the incomplete #147 I've made this change as per the comments on it.