-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use of arrays and keys in custom_cfg_[prepend,append].. #273
Conversation
Allow arrays to be specified as values in location_cfg_{prepend,append} and vhost_cfg_{ssl_,}{prepend,append} parameters.
Resolved Conflicts: spec/defines/resource_location_spec.rb templates/vhost/vhost_location_alias.erb templates/vhost/vhost_location_directory.erb templates/vhost/vhost_location_empty.erb templates/vhost/vhost_location_fastcgi.erb templates/vhost/vhost_location_proxy.erb templates/vhost/vhost_location_stub_status.erb
…eader,footer}. fix vhost_location_alias/vhost_location_directory. Add {location_custom_cfg_prepend,append} to vhost_location_fastcgi, vhost_location_proxy and vhost_location_stub_status.
related to your last commit, sort_by is neccesary becouse its expected order values. I see two type of errors
This is caused by different spacing
I replaced the extra space with # to highlight it
In this case seems not render test4 subtest1 "sub test value1b"; but all test that i did it was render fine and i cant resolve it :( |
Opps. forgot to push the revert. Done now.
fixed in two places. :( yep, saw that. I can't see the cause either. |
closing - see #266 |
location_cfg_{prepend,append} and vhost_cfg_{ssl_,}{prepend,append} parameters.
Forms a merger of #266 and #201
Doing a separate PR to see if travis passes it.