location_cfg_append can now acccept an array of values

[jtreminio]

Previously, location_cfg_append would only accept a single value, now you can pass an array:

$fastcgi_param = [
  'PATH_INFO $fastcgi_path_info',
  'PATH_TRANSLATED $document_root$fastcgi_path_info',
  'SCRIPT_FILENAME $document_root$fastcgi_script_name',
]

nginx::resource::location { "${server_name}-php":
  ensure              => present,
  vhost               => $server_name,
  location            => '~ \.php$',
  proxy               => undef,
  try_files           => ['$uri', '$uri/', "/${try_files}?\$args"],
  www_root            => $www_root,
  location_cfg_append => {
    'fastcgi_split_path_info' => '^(.+\.php)(/.+)$',
    'fastcgi_param'           => $fastcgi_param,
    'fastcgi_pass'            => $fastcgi_pass,
    'fastcgi_index'           => 'index.php',
    'include'                 => 'fastcgi_params'
  },
  notify              => Class['nginx::service'],
}

[jfryman]

What about casting value as an Array with Array()? That way you can avoid the if then dance here.

[jfryman]

Same with all the other examples.

[ghost]

You don't even need to do that much. If value is a String, <% value.each do |sub| %> will just loop through it once.

[3flex]

There's no each method on a string object in Ruby 1.9.1 and higher though. http://ruby-doc.org/core-1.9.1/String.html

[ghost]

Good to know. In that case, I think you can make it an array like so: <% Array(value).each do |sub| %>

[jtreminio]

@jfryman I'm coming from a non-ruby world, can you show me a quick, proper example so I can commit?

Thanks!

[3flex]

I don't think this needs to be removed for this PR.

[jfryman]

Way old. Thanks for taking a pass at this... going to revisit when 🕐 allows. Please reopen and rebase if you wanna take another pass at this.