Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy_set_header and vhost_cfg_prepend to the ssl vhost template. #179

Closed
wants to merge 1 commit into from

Conversation

haraldsk
Copy link

proxy_set_header and vhost_cfg_prepend was missing from ssl vhost template.

proxy_set_header is important in cases where nginx is used as a SSL proxy and the backend application need
to have custom headers appended to.

For instance Wordpress need headers like 'X-Forwarded-Proto https' to work properly with SSL proxying.

@hackzilla
Copy link

Seems to be failing in ruby 1.8.7

@3flex
Copy link
Contributor

3flex commented Nov 25, 2013

That was due to an issue with the tests which is now fixed.

@haraldsk if you rebase this should pass. Please also consider adding tests for this new functionality, you can base this on the new tests in spec/defines/resource_location_vhost.rb

@jhoblitt
Copy link
Member

I just hit this issue as well. @haraldsk - are you planning to update this PR?

@grooverdan
Copy link
Contributor

opps, #201 and #202 also covers this fix

@grooverdan
Copy link
Contributor

and this one at least partially fixes the test cases for them.

@haraldsk
Copy link
Author

@jhoblitt Haven't had the time. But it seems #202 is merged and all is good.

@jfryman
Copy link
Contributor

jfryman commented Jun 24, 2014

Way old. Thanks for taking a pass at this... going to revisit when 🕐 allows. Please reopen and rebase if you wanna take another pass at this.

@jfryman jfryman closed this Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants