-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8: Make the content tree keyboard accessible #5729
V8: Make the content tree keyboard accessible #5729
Conversation
# Conflicts: # src/Umbraco.Web.UI.Client/src/less/belle.less
Thanks @MMasey - before I look at this: we already have a |
Other than that, I LOVE what's happening in this GIF! |
Ah, don't mind me, I see you just moved the class 🤦♂️. Will have a look! |
YAY!! 🎉 🎖 🎈 This is such a relief.. being able to navigate the content tree with keyboard is my most favorite feature of the month! I'm going to do this all the time now. Top job @MMasey - SUPER useful! |
This PR makes the arrow to reveal child nodes, and the node options button (displayed as 3 dots when hovering over a node in the tree) in the content tree keyboard accessible. It also makes it easier to get to the context menu via the options menu when navigating via a keyboard.
As part of this work I discovered a separate issue where the
ESC
to close andclickOutside
to close functionality doesn't bind properly when accessing the context menu via the "Do something else" button in the options menu. We also discussed changing the "Do something else" with something more helpful, but that is a separate subject. This PR doesn't fix those issue, but I wanted to flag it to remind me to make an issue for it later.I've also refactored the
sr-only
class to include asr-only--focusable
andsr-only--hoverable
modifier class which. They should be used like so<button class="sr-only sr-only--focusable">Visible when focused</button>
Here is a gif of it in action.
This doesn't fix every accessibility issue with the every tree in the Umbraco backoffice, but it is a start.
P.S. Can this be given the
accessibility
label please