Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Remove "double tabbing" on context menu items (regression) #7381

Closed
wants to merge 1 commit into from

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Dec 22, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

#5729 adds some really nice improvements to keyboard navigation through the trees. Unfortunately an unintended side effect is that the tree context menu items now require two tab strokes each:

context-menu-tab-before

With this PR we're back to one per item:

context-menu-tab-after

@poornimanayar
Copy link
Contributor

Thanks @kjac , we will have a look and get back to you :-)

@nul800sebastiaan
Copy link
Member

I can't repro this in the latest v8/contrib so I believe it's been fixed somewhere else since then!

@kjac kjac deleted the v8/fix/context-menu-item-tabbing branch July 30, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants