V8: Create dialogs have horizontal overflow #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank @KennethJakobsen, I have no idea how I missed that 🤦♂ 😂 |
|
😆 I do believe @KennethJakobsen is receiving weird notifications from time to time |
|
😂 It's really not my day is it |
|
That ain't fair, #5729 is awesome 👍 |
|
PR updated with latest v8/dev |
nul800sebastiaan
pushed a commit
that referenced
this pull request
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The awesome work by @MMasey in 405e9a7 has had a bit of a negative impact on the create dialogs throughout the system (except in Content); there's a horizontal overflow going on:
Given how we should definitively keep on moving towards the goal from 405e9a7, I have updated all create dialogs according to the changes in that PR. This removes the overflow, and as a bonus it is a step along the way to make all of the create dialogs keyboard accessible.
When this PR is applied, the menus behave like you'd expect: