Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Fix broken button to open content type from create dialog #6041

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Aug 2, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The direct access to assign allowed child types to a content type from the "Create" dialog is currently broken:

edit-content-type-from-create-before

Looks like this is caused by the changes in #5729 (swapping the link for a button, thus making the href attribute meaningless).

This PR amends it, so the button works again:

edit-content-type-from-create-after

@kjac
Copy link
Contributor Author

kjac commented Aug 2, 2019

Reported as an issue here: #6048

@nul800sebastiaan nul800sebastiaan changed the base branch from v8/dev to v8/8.1 August 8, 2019 07:42
@nul800sebastiaan nul800sebastiaan changed the base branch from v8/8.1 to v8/dev August 8, 2019 07:42
@nul800sebastiaan nul800sebastiaan merged commit 57e58c6 into umbraco:v8/dev Aug 8, 2019
@nul800sebastiaan
Copy link
Member

Awesome, thanks @kjac !

@nul800sebastiaan
Copy link
Member

Cherry picked into 8.1.2 here beacc5b

@kjac kjac deleted the v8-fix-edit-content-type-from-create-dialog branch August 8, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants