add create language test #11307
add create language test #11307
Conversation
…ll notifications from within an Assembly
* Move sln files to root * Fix tests * Misc cleanup - remove unused helper * Document the esoteric nature of UmbracoWebApplicationFactory * Avoid unnecessary change to TestHelper WorkingDirectory
…-copy Copy static assets during BeforeBuild target to fix Visual Studio "rebuild" failures
There are some cases where there is a complex hosting strategy and folks want a readonly database and are hosting on Azure. In that case, it is not entirely possible to have a readonly Umbraco database because SqlMainDom is required and part of that requirement is to have read/write access to the umbraco key value table. This PR allows for the default MainDom to be replaced and to allow for an SqlMainDomLock to use an alternate connection string so that a separate read/write database can be used. (cherry picked from commit 9f48a9f)
umbraco#11231) * Remove inherited property group id/key when local properties are added * Rebind saved content type values * Remove inherited from save group (cherry picked from commit 20b9db8)
umbraco#11231) * Remove inherited property group id/key when local properties are added * Rebind saved content type values * Remove inherited from save group (cherry picked from commit 20b9db8)
# Conflicts: # src/SolutionInfo.cs # src/Umbraco.Core/Composing/CompositionExtensions/Services.cs # src/Umbraco.Infrastructure/Runtime/SqlMainDomLock.cs # src/Umbraco.Web/UmbracoApplication.cs
Signed-off-by: Nikolaj Geisle <[email protected]>
Co-authored-by: Mole <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Set culture from domain when internal redirecting due to public access
|
In later PRs (fx #11333) I've started adding the commands in the commands.js file which is the Cypress convention, I'm happy to move it wherever, but probably needs someone to make a decision about how it should be done 🙂 |
…xtension v9: Added Extension method to register all custom Notifications
…db_15 Also detect localdb 15
* Update gitignore * Move csproj * Update project references * Update solutions * Update build scripts * Tests used to share editorconfig with projects in src * Fix broken tests. * Stop copying around .editorconfig merged root one with linting * csharp_style_expression_bodied -> suggestion * Move StyleCop rulesets to matching directories and update shared build properties * Remove legacy build files, update NuGet.cofig and solution files * Restore myget source * Clean up .gitignore * Update .gitignore * Move new test classes to tests after merge * Gitignore + nuget config * Move new test Co-authored-by: Ronald Barendse <[email protected]>
…braco#11364) Co-authored-by: Ronald Barendse <[email protected]>
TinyMCE requires text to be selected in order to insert links. Added checks for if there is a text selection, and insert HTML content if there is not. Link contents consists of the target name, or the target url if not populated
Update background size property to `contain` so that the whole image shows
…o process and debug Umbraco source in VS Code / Codespaces (umbraco#11367)
|
@jemayn.. It's totally fine to just add them in |
Awesome @bergmania, what about the TS definitions then? 🙂 Or do I just add them without those? (The file for it is gitignored) |
I have no idea, we need a frontend dev to answer that 🙈 @madsrasmussen can you help answer 🙏 |
This reverts commit 1d2272f.
|
@jemayn That is a good question. I haven't spent much time with our cypress tests yet. 🙈 I went digging in their documentation but I can't figure out whether they want us to manually add them to a declaration file or through a reference comment. Maybe it makes better sense to you. This is what I found: https://docs.cypress.io/guides/tooling/typescript-support#Types-for-custom-commands It let me to this repo: |
|
Thanks @madsrasmussen , I will try to get it to work, had some issues for now with the rebase where Github shows a ton of changes but comparing the branches only shows 2 files. Please leave this open for now and I will get back to it soon 🙂 |
|
Closing this and remaking, did a rebase which for some reason shows all changes instead of just the ones between my branch and the target 🤷♂️ |
Prerequisites
If there's an existing issue for this PR then this fixes
Description
Adds a new Cypress test that creates a language.
I have a question about adding new cypress commands like the one I added at the bottom of my test file here. Seems all commands are currently imported from Bjarkes package - however that makes it super difficult to test and add new ones.
What is the preferred way to deal with this? Am I meant to do a PR to the package with the command and then open a PR here that depends on the other one being closed and a new NPM version of the package being released?
Doesn't seem that nice of a workflow for outside collaborators 🙂