Move test projects from src/ to tests/ #11357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-m-j
force-pushed
the
v9/misc/move-tests
branch
from
f39d6c2 to
bceab79
Compare
added 2 commits
October 12, 2021 13:28
merged root one with linting
ronaldbarendse
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
I've moved the code analysis rule sets to the corresponding root and tests directory (the tests inherit/import the rules from the root), where they get included by adding a <CodeAnalysisRuleSet> to the Directory.Build.props (which now also uses multi-level merge).
The legacy build files are also cleaned up, together with the .gitignore file, so this should make the repository structure easier to understand.
I tried to remove the custom MyGet feeds from the NuGet.config, but apparently version 1.2.0 of the Umbraco.Code package isn't available on nuget.org. We should either publish this version as well or otherwise integrate the project into the CMS solution (and take a project reference dependency).
ronaldbarendse
changed the title
p-m-j
commented
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.