v8: IEmailSender not registered in DI container

[mattbrailsford]

Which exact Umbraco version are you using? For example: 8.13.1 - don't just write v8

Umbraco v8.17.0-rc2

Bug summary

Umbraco has a IEmailSender for helping sending emails, but this isn't registered in the DI container like it is in v9. It currently requires use of a hard coded EmailSender class.

Specifics

No response

Steps to reproduce

Accept an IEmailSender constructor dependency.
Run application
Get error because it's not registered in container

Expected result / actual result

IEmailSender should be registered with the DI container and should successfully resolve as a constructor arg.

[nul800sebastiaan]

I made a bit of a mess but with some help from @p-m-j I got there in the end! Thanks for the report @mattbrailsford! 👍

[nul800sebastiaan]

Fixed in #11206 for 8.17.0.

[p-m-j]

Don't think you made a mess at all @nul800sebastiaan, the static helpers for services were the idiomatic way to work in umbraco for so long and I don't think there would have been a problem with adding one as long as the service was registered in the container.

Edit: Not having them is also fine, we should be encouraging constructor injection, especially for those preparing to move 8->9

[nul800sebastiaan]

Ah I was just referring to the mess with multiple PRs and forgetting to revert stuff. The final commit is nice and clean!