-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add delete language test #11380
add delete language test #11380
Conversation
Hi there @jemayn, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Great work once again @jemayn - works as advertised, thanks very much! ⭐ |
Thanks! I think we may need to fix this merge slightly though. Seems that during the time it has been open the test folder has moved, so now these files are committed in the wrong place 😊 I will try to fix it up during the hackathon on Friday if nothing has been done before then. |
(cherry picked from commit ba73a39)
Cherry picked for v8 in 427c85e |
(cherry picked from commit ba73a39)
Prerequisites
If there's an existing issue for this PR then this fixes
Description
The test creates a few languages through the API, then goes through UI to delete one of them.
This was demoed and worked on with all participants at the Umbraco London Meetup tonight.
Special thanks to @warrenbuckley @ravimotha @deanleigh for help debugging 🙂