Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete language test #11380

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

jemayn
Copy link
Contributor

@jemayn jemayn commented Oct 14, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

The test creates a few languages through the API, then goes through UI to delete one of them.

This was demoed and worked on with all participants at the Umbraco London Meetup tonight.
Special thanks to @warrenbuckley @ravimotha @deanleigh for help debugging 🙂

@jemayn jemayn mentioned this pull request Oct 14, 2021
7 tasks
@umbrabot
Copy link

umbrabot commented Oct 14, 2021

Hi there @jemayn, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan
Copy link
Member

Great work once again @jemayn - works as advertised, thanks very much! ⭐

@nul800sebastiaan nul800sebastiaan merged commit ba73a39 into umbraco:v9/contrib Oct 26, 2021
@jemayn
Copy link
Contributor Author

jemayn commented Oct 26, 2021

Hey @nul800sebastiaan

Thanks! I think we may need to fix this merge slightly though. Seems that during the time it has been open the test folder has moved, so now these files are committed in the wrong place 😊

I will try to fix it up during the hackathon on Friday if nothing has been done before then.

@jemayn jemayn mentioned this pull request Oct 29, 2021
@jemayn jemayn deleted the cy-delete-language branch October 29, 2021 18:27
nul800sebastiaan pushed a commit that referenced this pull request Nov 3, 2021
(cherry picked from commit ba73a39)
@nul800sebastiaan
Copy link
Member

Cherry picked for v8 in 427c85e

nul800sebastiaan pushed a commit that referenced this pull request Nov 3, 2021
(cherry picked from commit ba73a39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants