v8: Backoffice Welsh language translation updates #11240
Conversation
Merge upstream changes into OwainJ fork
… the en us language file)
|
Just to double-check, but which of the language files is considered the "source of truth" for translation keys? As currently, I've been basing the cy.xml file off of both the en.xml and en_us.xml files, but, I've noticed that there are lang keys present in other lang files that are not present in en, and vice versa, but I'm not sure if they are just old unused keys? Also, there are some keys present in cy.xml that are no longer present in en.xml, but I'm a little unsure on whether or not to remove them? |
OwainJ
changed the title
OwainJ
changed the title
|
Hi there @OwainJ, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Hey @OwainJ, to be honest, I'm not sure which files would be the most correct. I'd assume the English versions, but if there are discrepancies between those I'd err on the side of caution and include rather than exclude. I know there was some work done recently to clean up language files in v9, but that doesn't really help for v8. Difficult to clean up as keys can be generated in code too...
All said, this will be fine to merge - if you're adding keys that were missing, awesome, if any of those aren't in use there's no harm.
nathanwoulfe
added
category/ux
* Adjust icon in umb-checkbox and ensure icon is centered * Missing nl translation for blockEditor_addBlock * Implement icon parameter for doctype editor (#11008) * fix: implement icon parameter for doctype editor issue #10108 * fix: move color from icon to class attribute * fix: removed defined colors, defaulting to the standard dark grey (ie "no color picked" in icon picker) * cleaned up unused dependencies, double quotes to single, removed unused 'color' param from the create methods, and use shorthand object creation in createDocType (if the key has the same name as the variable passed as a prop, we only need to pass the key name) * fix comment Co-authored-by: Nathan Woulfe <[email protected]> * Align sortable handle vertically in multivalues prevalue editor * 10341: Use different picker for content types (#10896) * 10341: Use different picker for content types * use es6 where possible (inc removing underscore for teeny tiny performance improvement) Co-authored-by: Nathan Woulfe <[email protected]> * Falling back to contentTypeName when Block List label is empty (#10963) * Falling back to contentTypeName when Block List label is empty * Adding $contentTypeName variable for Block List labels * Fix incorrect attribute * Grid: Add button styling fix (#10978) * Add missing focus styling * Ensure add button is perfectly rounded and remove unused / uneeded CSS. * Remove redundant border-color property * Revert removal of unused css Co-authored-by: BatJan <[email protected]> Co-authored-by: Jan Skovgaard Olsen <[email protected]> * Create content template localization (#10945) * Don't use self-closing element for custom HTML elements * Use button element for close/cancel in copy dialog * Update localization of "createBlueprintFrom" Co-authored-by: Nathan Woulfe <[email protected]> * Cleanup examine search results, and adds ability to toggle fields (#9141) * Cleanup examine search results, and adds ability to toggle fields * update table to use joinarray filter with one-time binding to avoid recalculating filter values, updated filter to not explode when array arg is null * fix failing tests - improve filter to not fail on non-array params, update tests accordingly Co-authored-by: Nathan Woulfe <[email protected]> * Add EntityController GetUrlsByUdis Enables loading multiple URLs in a single request for Media & Documents * Update content picker to use GetUrlsByUdis * Allows replacing MainDom with alternate DB There are some cases where there is a complex hosting strategy and folks want a readonly database and are hosting on Azure. In that case, it is not entirely possible to have a readonly Umbraco database because SqlMainDom is required and part of that requirement is to have read/write access to the umbraco key value table. This PR allows for the default MainDom to be replaced and to allow for an SqlMainDomLock to use an alternate connection string so that a separate read/write database can be used. * Remove inherited property group id/key when local properties are added (#11231) * Remove inherited property group id/key when local properties are added * Rebind saved content type values * Remove inherited from save group * Rename parameter for clarity * Removes annoying wait text, which causes layout jank * v8: Backoffice Welsh language translation updates (#11240) * Updated the Welsh language file to include newly added keys (based on the en us language file) * Updated the searchInputDescription key * Updated the endTitle key * Use medium sized overlay * Use umb-icon component for icons in content type groups and tabs * fixes wrong reference to enterSubmitFolder method in ng-keydown * 11251: Don't add default dashboard to url * Fix preview of SVG when height and width not are set * If caching a published document, make sure you use the published Name… (#11313) * If caching a published document, make sure you use the published Name. Closes #11074. * Fix case of new node Co-authored-by: Moore, Douglas S <[email protected]> * Added missing Italian translations (#11197) * Resolve incorrect ContentSavedState for failed publish Closes #11290 (for v8) * add modelValue validation for server to correctly update validation errors * 11048: Bugfix for groups and properties that get replaced (#11257) (cherry picked from commit 1605dc1) * Icon fallback to `icon-document` for existing document types (#11283) * Align create buttons styling (#11352) * Added button for cancelling dictionary create action * Use hideMenu * Align dictionary create with the other creates * Align import documenttype * Align for data type folder create * Align document type create buttons * Forgot small ng-show * Align create media folder buttons * Align create macro buttons * Align create relation buttons * Align create partial view macro folder buttons * Align partial view folder create buttons * Align create scripts folder buttons * Align create scripts folder buttons * Use primary instead of success * V8: Duplicate MemberGroup names cause MemberGroup mixup (#11291) * Prevented duplicate member group names * Added English lang * Updated 'Exist' typo * add labels in FR and NL * Adding property group aliases to ex.message * Adding invalid prop group aliases as ModelState errors, so we don't introduce breaking changes * Pointing the actual reason for invalidating composition * Validate all content type dependencies and throw a single InvalidCompositionException * Rename based on review comments * Update composition validation error messages * Update InvalidCompositionException message * Allow switching property editor from numeric to slider (#11287) * Make it possible to change from numeric/decimal property editor to slider without breaking editor * Formatting * Enables friendly pasting in multipletextbox * UI API docs: Added reset rules for .close class * UI API docs: Fixed incorrect method name * 11331: Check property on instance if id is not set yet * Fixed cypress tests Co-authored-by: Bjarne Fyrstenborg <[email protected]> Co-authored-by: Corné Strijkert <[email protected]> Co-authored-by: Søren Gregersen <[email protected]> Co-authored-by: Nathan Woulfe <[email protected]> Co-authored-by: patrickdemooij9 <[email protected]> Co-authored-by: Callum Whyte <[email protected]> Co-authored-by: Jan Skovgaard <[email protected]> Co-authored-by: BatJan <[email protected]> Co-authored-by: Jan Skovgaard Olsen <[email protected]> Co-authored-by: Søren Kottal <[email protected]> Co-authored-by: Paul Johnson <[email protected]> Co-authored-by: Shannon <[email protected]> Co-authored-by: Sebastiaan Janssen <[email protected]> Co-authored-by: Ronald Barendse <[email protected]> Co-authored-by: Owain Jones <[email protected]> Co-authored-by: Mole <[email protected]> Co-authored-by: Doug Moore <[email protected]> Co-authored-by: Moore, Douglas S <[email protected]> Co-authored-by: Martino Gabrielli <[email protected]> Co-authored-by: Nikolaj Geisle <[email protected]> Co-authored-by: Mads Rasmussen <[email protected]> Co-authored-by: Jamie Townsend <[email protected]> Co-authored-by: Elitsa Marinovska <[email protected]> Co-authored-by: Anders Bjerner <[email protected]>
|
Hi there @OwainJ, First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 31st, 2021. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏 We have blogged about this year's hacktoberfest in a recap post, have a read about at all the achievements for this year! The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
Description
Updated the Welsh language backoffice translation file to include new keys found in the en and en_us language files.