11048: Bugfix for groups and properties that get replaced #11257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there @patrickdemooij9, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Thanks @patrickdemooij9 - this now has a merge conflict due to this fix: #11231 - I'll try out the other fix and see if that fixes this issue as well. |
|
Thanks @nul800sebastiaan , let me know if the other fix fixes this issue as well. Otherwise I will fix the merge conflict here. |
# Conflicts: # src/Umbraco.Web.UI.Client/src/views/documentTypes/edit.controller.js
|
I've fixed the merge conflict and this fixes the actual issue! So my only question really is, why does I am just not sure preventing a rebind wouldn't cause other errors that were fixed in #11231 and previous fixes. So I need a bit more of an idea of what is happening please 👍 We need to cherry-pick #11231 and this one to v8 as well by the way. |
|
@nul800sebastiaan, Should I also create a different PR for this that target V8? So we also have the fix on there? |
|
@patrickdemooij9 No need for a separate v8 one, I can cherry pick this one once merged. Cool, I'll have a look at logging to the console during debug to make sure we're seeing the expected output! 👍 |
|
Alright, I tried a lot of whacky things and this seems to help indeed! 👍 |
nul800sebastiaan
pushed a commit
that referenced
this pull request
Oct 12, 2021
(cherry picked from commit 1605dc1)
|
Cherry picked for v8.18 here: d02440d |
bergmania
added a commit
that referenced
this pull request
Oct 20, 2021
* Adjust icon in umb-checkbox and ensure icon is centered * Missing nl translation for blockEditor_addBlock * Implement icon parameter for doctype editor (#11008) * fix: implement icon parameter for doctype editor issue #10108 * fix: move color from icon to class attribute * fix: removed defined colors, defaulting to the standard dark grey (ie "no color picked" in icon picker) * cleaned up unused dependencies, double quotes to single, removed unused 'color' param from the create methods, and use shorthand object creation in createDocType (if the key has the same name as the variable passed as a prop, we only need to pass the key name) * fix comment Co-authored-by: Nathan Woulfe <[email protected]> * Align sortable handle vertically in multivalues prevalue editor * 10341: Use different picker for content types (#10896) * 10341: Use different picker for content types * use es6 where possible (inc removing underscore for teeny tiny performance improvement) Co-authored-by: Nathan Woulfe <[email protected]> * Falling back to contentTypeName when Block List label is empty (#10963) * Falling back to contentTypeName when Block List label is empty * Adding $contentTypeName variable for Block List labels * Fix incorrect attribute * Grid: Add button styling fix (#10978) * Add missing focus styling * Ensure add button is perfectly rounded and remove unused / uneeded CSS. * Remove redundant border-color property * Revert removal of unused css Co-authored-by: BatJan <[email protected]> Co-authored-by: Jan Skovgaard Olsen <[email protected]> * Create content template localization (#10945) * Don't use self-closing element for custom HTML elements * Use button element for close/cancel in copy dialog * Update localization of "createBlueprintFrom" Co-authored-by: Nathan Woulfe <[email protected]> * Cleanup examine search results, and adds ability to toggle fields (#9141) * Cleanup examine search results, and adds ability to toggle fields * update table to use joinarray filter with one-time binding to avoid recalculating filter values, updated filter to not explode when array arg is null * fix failing tests - improve filter to not fail on non-array params, update tests accordingly Co-authored-by: Nathan Woulfe <[email protected]> * Add EntityController GetUrlsByUdis Enables loading multiple URLs in a single request for Media & Documents * Update content picker to use GetUrlsByUdis * Allows replacing MainDom with alternate DB There are some cases where there is a complex hosting strategy and folks want a readonly database and are hosting on Azure. In that case, it is not entirely possible to have a readonly Umbraco database because SqlMainDom is required and part of that requirement is to have read/write access to the umbraco key value table. This PR allows for the default MainDom to be replaced and to allow for an SqlMainDomLock to use an alternate connection string so that a separate read/write database can be used. * Remove inherited property group id/key when local properties are added (#11231) * Remove inherited property group id/key when local properties are added * Rebind saved content type values * Remove inherited from save group * Rename parameter for clarity * Removes annoying wait text, which causes layout jank * v8: Backoffice Welsh language translation updates (#11240) * Updated the Welsh language file to include newly added keys (based on the en us language file) * Updated the searchInputDescription key * Updated the endTitle key * Use medium sized overlay * Use umb-icon component for icons in content type groups and tabs * fixes wrong reference to enterSubmitFolder method in ng-keydown * 11251: Don't add default dashboard to url * Fix preview of SVG when height and width not are set * If caching a published document, make sure you use the published Name… (#11313) * If caching a published document, make sure you use the published Name. Closes #11074. * Fix case of new node Co-authored-by: Moore, Douglas S <[email protected]> * Added missing Italian translations (#11197) * Resolve incorrect ContentSavedState for failed publish Closes #11290 (for v8) * add modelValue validation for server to correctly update validation errors * 11048: Bugfix for groups and properties that get replaced (#11257) (cherry picked from commit 1605dc1) * Icon fallback to `icon-document` for existing document types (#11283) * Align create buttons styling (#11352) * Added button for cancelling dictionary create action * Use hideMenu * Align dictionary create with the other creates * Align import documenttype * Align for data type folder create * Align document type create buttons * Forgot small ng-show * Align create media folder buttons * Align create macro buttons * Align create relation buttons * Align create partial view macro folder buttons * Align partial view folder create buttons * Align create scripts folder buttons * Align create scripts folder buttons * Use primary instead of success * V8: Duplicate MemberGroup names cause MemberGroup mixup (#11291) * Prevented duplicate member group names * Added English lang * Updated 'Exist' typo * add labels in FR and NL * Adding property group aliases to ex.message * Adding invalid prop group aliases as ModelState errors, so we don't introduce breaking changes * Pointing the actual reason for invalidating composition * Validate all content type dependencies and throw a single InvalidCompositionException * Rename based on review comments * Update composition validation error messages * Update InvalidCompositionException message * Allow switching property editor from numeric to slider (#11287) * Make it possible to change from numeric/decimal property editor to slider without breaking editor * Formatting * Enables friendly pasting in multipletextbox * UI API docs: Added reset rules for .close class * UI API docs: Fixed incorrect method name * 11331: Check property on instance if id is not set yet * Fixed cypress tests Co-authored-by: Bjarne Fyrstenborg <[email protected]> Co-authored-by: Corné Strijkert <[email protected]> Co-authored-by: Søren Gregersen <[email protected]> Co-authored-by: Nathan Woulfe <[email protected]> Co-authored-by: patrickdemooij9 <[email protected]> Co-authored-by: Callum Whyte <[email protected]> Co-authored-by: Jan Skovgaard <[email protected]> Co-authored-by: BatJan <[email protected]> Co-authored-by: Jan Skovgaard Olsen <[email protected]> Co-authored-by: Søren Kottal <[email protected]> Co-authored-by: Paul Johnson <[email protected]> Co-authored-by: Shannon <[email protected]> Co-authored-by: Sebastiaan Janssen <[email protected]> Co-authored-by: Ronald Barendse <[email protected]> Co-authored-by: Owain Jones <[email protected]> Co-authored-by: Mole <[email protected]> Co-authored-by: Doug Moore <[email protected]> Co-authored-by: Moore, Douglas S <[email protected]> Co-authored-by: Martino Gabrielli <[email protected]> Co-authored-by: Nikolaj Geisle <[email protected]> Co-authored-by: Mads Rasmussen <[email protected]> Co-authored-by: Jamie Townsend <[email protected]> Co-authored-by: Elitsa Marinovska <[email protected]> Co-authored-by: Anders Bjerner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's an existing issue for this PR then this fixes #11048
Steps for reproducing the bug can be found in the issue.
The issue was that whenever the save API call would return an error (due to the duplicate aliases here), it would still rebind the properties & groups based on their alias. So if you have a duplicate alias, they would both get the same id which eventually makes it so that the last property will override the first one.
I am not really sure why the code is rebinding on an error as there isn't anything saved at that point. However, I have not encountered any issues with not rebinding the properties & groups on an error. If there is a scenario that I haven't tested yet where this is important, then please let me know and I'll take a look at it.