Align create buttons styling

[patrickdemooij9]

@nathanwoulfe suggested to add a cancel button to the create screen of a dictionary item, so here it is:

Can be tested by trying to create a new dictionary item and then cancelling it through the button.

[umbrabot]

Hi there @patrickdemooij9, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[bjarnef]

I would place the close/cancel button to the left as it is more consistent with other dialogs.
Furthermore I noticed the create/rename folder dialogs for e.g. document types, media types, datatypes doesn't have a close/cancel button either.

It is possible to close via esc shortcut or click outside, but better to include a button to close these as well :)

[patrickdemooij9]

@bjarnef , good point! Will take a look at all the other spots tomorrow.

I was thinking that the buttons should be moved to the footer of the dialog to be more consistent with other ones? Create content template has it like this:

And basically all other dialogs for content has it like this. Would be better to align them all, I think?

[patrickdemooij9]

Oke, I've done some updating here. I've updated the following screens:

• Dictionary Create
• Document Type Import
• Document Type Folder Create
• Data Type Folder Create
• Media Type Folder Create
• Macro Create
• Relation Create
• Partial View Macro Folder Create
• Partial View Folder Create
• Scripts Folder Create
• Stylesheet Folder Create

To follow the styling like this:

With a close button added to each of the screens and moving the buttons to the bottom of the screen.

[nathanwoulfe]

This is awesome, thanks @patrickdemooij9. Absolutely above and beyond - I'd suggested one button, you've delivered 11!

Will get to this today, should be a quick and easy review then off to Merge City.

[nathanwoulfe]

Lovely, all works correctly - cancel button for each example closes the overlay, create button does the expected creating. All consistently rendered in the dialog footer. Thanks @patrickdemooij9!