update templates for diag_table to be consistent with model_configure #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aerorahul Just FYI, the "templating" files were initially introduced when S2S was being run using the Python based CompsetRunner that Sam built. They are overdue for updating to whatever works best now that all applications are using the rt.sh infrastructure. |
…sics (was PR #755) (#756) * update CICE for added memory profiling * update stochastic_physics for memory fix leak co-authors: @lisa-bengtsson , @pjpegion
* updated fv3atm * updated fv3_conf/compile_slurm.IN_gaea to use proper queue with ecflow * updated ufs_common modulefiles to use newly installed FMS 2021.03 library
…ublic release (#772) This PR brings in an update for fv3atm that contains updates to the latest public release of the FV3 dycore. This PR changes answers for all regional tests and any test with ICs created by chgres from sources that sets the data_source_fv3gfs=.true. option in FV3/atmos_cubed_sphere/tools/external_ic.F90::get_nggps_ic routine. * updated ICs to use newly created 20210825 snapshot * bypass control_csawmg test for gaea (numerical instability) * updated BL_DATE in anticipation of baseline creation
* use fms lib built with avx on hera, update baseline date
…orahul/ufs-weather-model into feature/diag_template_update
…orahul/ufs-weather-model into feature/diag_template_update
|
Github PR shows 29 files changed, when there are only 5 actually changed. |
13 tasks
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
…lues (#759) * Modify RRFS North America 3- and 13-km domain configuration and WE2E test. * Modify default ISEED values for SPP * Fix grid in WE2E test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories. There is no change to the sub-components associated with this PR.
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. See issue move diag_table/field_table from input directory to tests/parm in the repository #644
Description
The
diag_tabletemplates (and other e.g. MOM6, WW3, ICE) employ different templating than the ones used ininput.nml,model_configureandnems.configure. These files use the template defined via@[VARIABLE]which is replaced by$VARIABLEdefined upstream.The workflow team would like to use the templates from the UFS-weather-model for constructing the necessary input files.
This will allow the workflow and the model to use the same templates, albeit filled with application specific values for the templated variables.
No change of answers is expected from this PR.
There is no impact on the general user running regression tests.
There are no library or modulefiles updated or need changes with this PR.
Issue(s) addressed
Testing
These have not been tested by running the model on any platform in particular with the exception that the change produces the desired output
diag_filefrom the template as before.Dependencies
None.