Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move diag_table/field_table from input directory to tests/parm in the repository #644

Closed
junwang-noaa opened this issue Jun 15, 2021 · 6 comments · Fixed by #921
Closed
Labels
enhancement New feature or request

Comments

@junwang-noaa
Copy link
Collaborator

Description

Currently the diag_table and field_table are located in the input data directory. There are some discussion to move those small model test related configuration files to test/parm directory so that updates in those files can be better tracked.
Another updates are to clean up the template variable replacement. Currently there are two different ways to replace the variable values in the template, it would be good if we can clean them up to avoid confusion.

Solution

  1. Move diag_table/field_table from input data directory to tests/parm directory and modify RT script to copy correct table in the run directory.
  2. Use @[] in the templates for variable replacement.

Related to

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

  • required to support noaa-emc/nems/issues/<issue_number>
  • needed by noaa-emc/fv3atm/pull/<pr_number>
@junwang-noaa
Copy link
Collaborator Author

@BinLiu-NOAA I noticed in your last commit, the field_table was changed back to the one in input directory (input-data-20210930/FV3_hafs_input_data/field_table), while in the PR #870 the field_table is from ufs-weather-model/tests/parm/field_table/field_table_hafs. I am not removing all the field_tables in the input directory, but the HAFS tests will change due to the difference in the two field_tables. Do you want to change the ufs-weather-model/tests/parm/field_table/field_table_hafs to input-data-20210930/FV3_hafs_input_data/field_table?

@BinLiu-NOAA
Copy link
Contributor

@junwang-noaa, please help to delete the FV3_hafs_input_data/field_table file when preparing a new version INPUT DATA. We would like to use this one (ufs-weather-model/tests/parm/field_table/field_table_hafs) instead. BTW, please also help to delete this FV3_hafs_regional_input_data directory (which is no longer needed). Thanks!

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Nov 10, 2021 via email

@BinLiu-NOAA
Copy link
Contributor

Thanks @junwang-noaa!

@JessicaMeixner-NOAA
Copy link
Collaborator

@junwang-noaa we could remove all of the older WW3_input_data_* directories, except for the most recent one if you are working to clean-up and create a new input directory.

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Nov 10, 2021 via email

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
* Add FV3_GFS_v15_thompson_mynn_lam3km

* Add a we2e test for thompson_mynn_lam3km

* Update namelist files

* Add MERRA2 data

* Fix typos

* Move the SDF line in scripts

* remove change of nstf_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants