update templates for diag_table to be consistent with model_configure #781
Conversation
|
Automated RT Failure Notification |
|
Automated RT Failure Notification |
|
Automated RT Failure Notification |
|
RT JOBS PASSED: wcoss_dell_p3. Log file uploaded.
|
Automated RT Failure Notification |
## DESCRIPTION OF CHANGES: PR #[763](ufs-community/regional_workflow#763) introduced the experiment variable `POST_OUTPUT_DOMAIN_NAME` and used it to modify the names of the UPP output files. This PR adds `POST_OUTPUT_DOMAIN_NAME` as an argument to the python plotting scripts to enable those scripts to form the proper UPP output file names to read in. It also modifies the batch scripts (`qsub_job.sh`, `qsub_job_diff.sh`, `sq_job.sh`, and `sq_job_diff.sh`) to add the new argument to the calls to the python plotting scripts that are called. ## TESTS CONDUCTED: Both python plotting scripts `plot_allvars.py` and `plot_allvars_diff.py` were run on Hera on preexisting UPP output files and completed successfully. The batch scripts `sq_job.sh` and `sq_job_diff.sh` were also run successfully on Hera (`qsub_job.sh` and `qsub_job_diff.sh` were not run on e.g. Cheyenne). ## DEPENDENCIES: PR # in `ufs-srweather-app`. ## DOCUMENTATION: Modifications to the documentation are in PR #. ## ISSUE: Partially resolves issue #781 (still need to introduce tests in `regional_workflow` that run the plotting scripts). ## CONTRIBUTORS: @mark-a-potts pointed out the problem and first made the necessary fixes in the `NOAA-EPIC` fork of `regional_workflow`; @gsketefian introduced those changes to this PR and made edits to the comments and documentation.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories. There is no change to the sub-components associated with this PR.
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. See issue move diag_table/field_table from input directory to tests/parm in the repository #644
Description
The
diag_tabletemplates (and other e.g. MOM6, WW3, ICE) employ different templating than the ones used ininput.nml,model_configureandnems.configure. These files use the template defined via@[VARIABLE]which is replaced by$VARIABLEdefined upstream.The workflow team would like to use the templates from the UFS-weather-model for constructing the necessary input files.
This will allow the workflow and the model to use the same templates, albeit filled with application specific values for the templated variables.
No change of answers is expected from this PR.
There is no impact on the general user running regression tests.
There are no library or modulefiles updated or need changes with this PR.
This PR is a re-opening of #759
Issue(s) addressed
Testing
These have not been tested by running the model on any platform in particular with the exception that the change produces the desired output
diag_filefrom the template as before.Dependencies
fv3atm 378