Re-enable regression test fv3_gsd_diag_debug / fix bug of using wrong temperature over water in RUC LSM

[climbfuji]

Description

As discussed in length in #821, a bug fix is required to initialize cold start runs with RUC LSM correctly over water points:

diff --git a/physics/sfc_drv_ruc.meta b/physics/sfc_drv_ruc.meta
index 52b76825..692f1712 100644
--- a/physics/sfc_drv_ruc.meta
+++ b/physics/sfc_drv_ruc.meta
@@ -199,7 +199,7 @@
   intent = in
   optional = F
 [tsfc_wat]
-  standard_name = surface_skin_temperature_over_water
+  standard_name = sea_surface_temperature
   long_name = surface skin temperature over water
   units = K
   dimensions = (horizontal_dimension)

This will change the results for all regression tests using RUC LSM.

Once this change is made, re-enable regression test fv3_gsd_diag_debug in rt.conf.

[DeniseWorthen]

Do we think this explains the failures for the fv3_gsd test seen in PR #863?

[SMoorthi-emc]

Probably not. The current issue is because I changed the name of the variable in the meta file to make it correct, but it caused some issues.

…

On Thu, Oct 21, 2021 at 7:24 PM Denise Worthen ***@***.***> wrote: Do we think this explains the failures for the fv3_gsd test seen in PR #863 <#863>? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#883 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYQZE3MMFO2DUNIWHJLUICOI7ANCNFSM5GO6ALCA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718