Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interstitial variables for land and ice emissivity and update the land and ice emissivity in the routine setemis in CCPP #821

Merged
merged 37 commits into from
Oct 22, 2021
Merged

Remove interstitial variables for land and ice emissivity and update the land and ice emissivity in the routine setemis in CCPP #821

merged 37 commits into from
Oct 22, 2021

Conversation

SMoorthi-emc
Copy link
Contributor

@SMoorthi-emc SMoorthi-emc commented Sep 21, 2021 •
edited by junwang-noaa
Loading

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
This PR updates fv3atm and ccpp-physics by removing interstitial variables for land and ice emissivity and updates the calculation of ice and (land for noah LSM) emissivity in radiation_surface.f. Eliminating the extra interstitial variables also leads to restart reproducibility.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI: 31a5bbe

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>
    Yes, PR #383 of fv3 atm and PR # 736 from ccpp-physics need to be merged first.

@climbfuji climbfuji added Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Sep 22, 2021
@github-actions github-actions bot removed the run-ci label Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

@SMoorthi-emc please bring these up to date with respective authoritative repositories

  • cmake NOT up to date

@SMoorthi-emc
Copy link
Contributor Author

SMoorthi-emc commented Oct 7, 2021 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 7, 2021 via email

@SMoorthi-emc
Copy link
Contributor Author

SMoorthi-emc commented Oct 21, 2021 via email

@climbfuji
Copy link
Collaborator

@SMoorthi-emc  Would you please check the fv3 revision in your ufs-weather-model branch? It points back to fv3 committed two days ago with fc513f3, while your latest fv3 revision is:1800bff

Does this mean that the new baseline on Cheyenne/Intel won't be correct?

@junwang-noaa
Copy link
Collaborator

Yes if you started creating new baseline after Moorthi's last commit (2 hours ago).

@SMoorthi-emc
Copy link
Contributor Author

SMoorthi-emc commented Oct 21, 2021 via email

@climbfuji
Copy link
Collaborator

I think it should be fine. That.last update does not change numbers. Moorthi
…

Thanks - we will see what auto-rt on Cheyenne says.

@SMoorthi-emc
Copy link
Contributor Author

SMoorthi-emc commented Oct 21, 2021 via email

@SMoorthi-emc
Copy link
Contributor Author

SMoorthi-emc commented Oct 22, 2021 via email

@junwang-noaa
Copy link
Collaborator

@SMoorthi-emc the cray log file is at: /scratch1/NCEPDEV/stmp2/Jun.Wang/wcosslog/RegressionTests_wcoss_cray.log, I can't commit it on wcoss.

@SMoorthi-emc
Copy link
Contributor Author

SMoorthi-emc commented Oct 22, 2021 via email

@climbfuji
Copy link
Collaborator

Looks like we've got everything. I'll merge the ccpp-physics PR.

@climbfuji climbfuji changed the title updating fv3atm to point to branch SM_Sept21_PR Remove interstitial variables for land and ice emissivity and update the land and ice emissivity in the routine setemis in CCPP Oct 22, 2021
@climbfuji
Copy link
Collaborator

@SMoorthi-emc Same procedure as beforehand, please. New fv3atm hash is 43c0982.

@SMoorthi-emc
Copy link
Contributor Author

SMoorthi-emc commented Oct 22, 2021 via email

@climbfuji climbfuji merged commit b87cdaa into ufs-community:develop Oct 22, 2021
JianpingHuang-NOAA pushed a commit to JianpingHuang-NOAA/ufs-weather-model that referenced this pull request Oct 5, 2023
@chan-hoo
[production/AQM.v7] Add ecFlow option to production branch for AQM (u…
cac37b9 
…fs-community#821)

* add ecflow to prod

* add defn and env file for ecflow

* change template

* fix load modules in scripts

* mv ecf to homedir

* change paths for nco variables

* make complete flag only for rocoto

* bug fix in default fcst_len_cycl

* add missing include

* replace exec with bash for ecflow

* update data_cleanup scripts

* fix bug on aqm_ics

* update aqm_lbcs script

* update ecf suite name

* remove unnecessary lines

* add testing flag

* update sample script

* fix wrong if range

* Fix bug in aqm_manager script

* update aqm_manager script

* move boolify for nco env to job_preamble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@DeniseWorthen DeniseWorthen DeniseWorthen approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@climbfuji climbfuji climbfuji approved these changes

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SMoorthi-emc @junwang-noaa @MinsukJi-NOAA @BrianCurtis-NOAA @climbfuji @tanyasmirnova @DeniseWorthen @DusanJovic-NOAA