-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable debugging features in CCPP physics caps, bug fixes and cleanup for CCPP variables and metadata, port model to XSEDE Expanse, switch WW3 from develop to dev/ufs-weather-model #850
Enable debugging features in CCPP physics caps, bug fixes and cleanup for CCPP variables and metadata, port model to XSEDE Expanse, switch WW3 from develop to dev/ufs-weather-model #850
Conversation
Automated RT Failure Notification |
Automated RT Failure Notification |
Sigh. The usual timeout. We need to do something about this test. I'll rerun the failed BL job manually, complete the baseline and add the RT label afterwards. |
If you want you can try adding changes I made in this branch: |
Please remind me again before I work on my next PR in a bit more than a week. I am hesitant to update this PR so late in the process (most regression tests finished so far). Thanks! |
@DusanJovic-NOAA All submodule PRs have been merged and I verified the hashes. Please review and merge if ok. Thanks! |
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR updates the submodule pointers for fv3atm (GFDL_atmos_cubed_sphere, ccpp-framework, ccpp-physics) and stochastic_physics for the changes described in detail in the associated PRs below:
It also ports the model to the XSede Expanse system (contributed by @MinsukJi-NOAA).
Switch WW3 from develop to dev/ufs-weather-model (i.e. pull #850 into this PR). This changes the results (metadata) for two regression tests, see #850 for more information. No change to input data.
Also: bug fix in
run_compile.sh
, replaceUNIT_TEST
withOPNREQ_TEST
.Update 10/22/2021: The bug fixes for issue #883 change the results of all regression tests using RUC LSM.
Issue(s) addressed
Fixes #883
Fixes NCAR/ccpp-framework#405
Testing
Regression tests were run on Cheyenne with Intel and GNU against the existing baselines on 10/04/2021. All tests passed.
RegressionTests_cheyenne.gnu.log
RegressionTests_cheyenne.intel.log
Update 10/22/2021: with the updates for RUC LSM and WW3, the following baselines change (confirmed by manually comparing the Hera Intel 20211019 and 20211022 baselines):
Full regression tests will be run on all tier-1 platforms when it is time to merge:
Dependencies