-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding semi-lagrangian sedimentation of rain in Thompson MP as an option #863
adding semi-lagrangian sedimentation of rain in Thompson MP as an option #863
Conversation
@RuiyuSun What are the namelist options required? Can they be added as variable settings in default_vars in order to turn this option on or off? |
The namellist options are
logical :: sedi_semi !< flag for semi Lagrangian sedi of
rain
logical :: sedi_semi_update!< flag for v update in semi
Lagrangian sedi of rain
logical :: sedi_semi_decfl !< flag for iteration with semi
Lagrangian sedi of rain
…On Wed, Oct 13, 2021 at 8:12 AM Denise Worthen ***@***.***> wrote:
@RuiyuSun <https://github.com/RuiyuSun> What are the namelist options
required? Can they should be added as variable settings in default_vars in
order to turn this option on or off.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#863 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFOCLFOM6JSKVH224JUQM3UGVZRRANCNFSM5FUBYNSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Ruiyu Sun, PhD
*IMSG* at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2097
College Park, MD 20740
***@***.*** ***@***.***>
301-683-3787
|
@jiandewang baseline was copied to emc.nemspara. The hera.intel baseline was also created. I will submit hera.intel RT. |
Automated RT Failure Notification |
Automated RT Failure Notification |
All the failed runs with hera.intel have slurm error: srun: Job step aborted: Waiting up to 32 seconds for job step to finish. Will rerun the three tests. |
FYI, I started creating baselines manually on Cheyenne w/ Intel to get this PR across the finishing line. |
Baseline creation on Cheyenne is complete, will run the verify step now. This is the last platform before we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fv3 and mom6 repo need to point to official repo as the commit. After that, the code can be committed
I just asked Jessica and Denise do the reviewing and approving of MOM6 PR, will merge it once it's approved by them |
@RuiyuSun MOM6 has just merged to dev/emc. you need to make change in .gitmodules change to |
... and update the submodule pointer (hash) to point back to the head of the dev/emc branch in the EMC fork ... |
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR is to add a semi-Lagrangian option of rain sedimentation to the Thompson microphysics scheme. The default relevant namelist values are set to false. To use the method, namelist values need to be changed.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
fix issue #724
fix issue #876
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
NCAR/ccpp-physics#727
NOAA-EMC/fv3atm#382