Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding semi-lagrangian sedimentation of rain in Thompson MP as an option #863

Merged
merged 35 commits into from
Oct 28, 2021

Conversation

RuiyuSun
Copy link
Contributor

@RuiyuSun RuiyuSun commented Oct 8, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

This PR is to add a semi-Lagrangian option of rain sedimentation to the Thompson microphysics scheme. The default relevant namelist values are set to false. To use the method, namelist values need to be changed.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
fix issue #724
fix issue #876

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

NCAR/ccpp-physics#727
NOAA-EMC/fv3atm#382

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Oct 13, 2021

@RuiyuSun What are the namelist options required? Can they be added as variable settings in default_vars in order to turn this option on or off?

@RuiyuSun
Copy link
Contributor Author

RuiyuSun commented Oct 13, 2021 via email

@junwang-noaa
Copy link
Collaborator

@jiandewang baseline was copied to emc.nemspara. The hera.intel baseline was also created. I will submit hera.intel RT.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/754214634/20211027181511/ufs-weather-model
Please manually delete: /glade/scratch/dtcufsrt/FV3_RT/rt_25415
Test compile 002 failed failed
Test compile_002 failed in run_compile failed
Test compile 006 failed failed
Test compile_006 failed in run_compile failed
Test compile 008 failed failed
Test compile_008 failed in run_compile failed
Test compile 011 failed failed
Test compile 007 failed failed
Test compile_011 failed in run_compile failed
Test compile_007 failed in run_compile failed
Please make changes and add the following label back:
cheyenne-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/754214634/20211028004511/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_25032
Test cpld_decomp_p7 004 failed failed
Test cpld_decomp_p7 004 failed in run_test failed
Test control_atm_aerosols 093 failed failed
Test control_atm_aerosols 093 failed in run_test failed
Test hafs_regional_docn_oisst 079 failed failed
Test hafs_regional_docn_oisst 079 failed in run_test failed
Please make changes and add the following label back:
hera-intel-RT

@junwang-noaa
Copy link
Collaborator

All the failed runs with hera.intel have slurm error:

srun: Job step aborted: Waiting up to 32 seconds for job step to finish.
slurmstepd: error: *** JOB 24617990 ON h36m06 CANCELLED AT 2021-10-28T01:37:33 DUE TO TIME LIMIT ***
0: slurmstepd: error: *** STEP 24617990.0 ON h36m06 CANCELLED AT 2021-10-28T01:37:33 DUE TO TIME LIMIT ***

Will rerun the three tests.

@climbfuji
Copy link
Collaborator

FYI, I started creating baselines manually on Cheyenne w/ Intel to get this PR across the finishing line.

@climbfuji
Copy link
Collaborator

Baseline creation on Cheyenne is complete, will run the verify step now. This is the last platform before we can merge.

Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fv3 and mom6 repo need to point to official repo as the commit. After that, the code can be committed

@jiandewang
Copy link
Collaborator

I just asked Jessica and Denise do the reviewing and approving of MOM6 PR, will merge it once it's approved by them

@jiandewang
Copy link
Collaborator

@RuiyuSun MOM6 has just merged to dev/emc. you need to make change in .gitmodules
url = https://github.com/jiandewang/MOM6
branch = feature/update-to-GFDL-20211019

change to
url = https://github.com/NOAA-EMC/MOM6
branch = dev/emc

@climbfuji
Copy link
Collaborator

@RuiyuSun MOM6 has just merged to dev/emc. you need to make change in .gitmodules url = https://github.com/jiandewang/MOM6 branch = feature/update-to-GFDL-20211019

change to url = https://github.com/NOAA-EMC/MOM6 branch = dev/emc

... and update the submodule pointer (hash) to point back to the head of the dev/emc branch in the EMC fork ...

@junwang-noaa junwang-noaa merged commit 12cda3f into ufs-community:develop Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants