-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump esp-tools (March 2021) #837
Conversation
Should this also include a bump of upstream riscv-isa-sim and riscv-pk to keep them in sync? |
This PR is ready. Check the PR listed above for submodule PR. |
Could this PR also bump riscv-tools to the equivalent commits, so we can make sure that esp-tools and riscv-tools are aligned? |
Someone touched the instruction struct in the upstream Spike after my PR for multi-extension support was merged, breaking all of our custom extensions. Time is running out, so I am only modifying |
Never mind, they fixed it in the latest version of spike. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspecting there might bit a merge issue that may have overwritten some files (in particular, extension reset within spike_main/spike.cc
) , but will merge this since tests seem to pass with hwacha, and gemmini has added a workaround in the tests.
Related issue: N/A
Type of change: other enhancement
Impact: software change
Release Notes
Bump esp-tools to March 2021 version