Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font-weight utility classes #18433

Closed
tarkhov opened this issue Dec 5, 2015 · 4 comments
Closed

Add font-weight utility classes #18433

tarkhov opened this issue Dec 5, 2015 · 4 comments

Comments

@tarkhov
Copy link

tarkhov commented Dec 5, 2015

// Text weights - https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#Common_weight_name_mapping
.text-black {
  font-weight: 900;
}

.text-extra-bold {
  font-weight: 800;
}

.text-bold {
  font-weight: 700;
}

.text-semi-bold {
  font-weight: 600;
}

.text-medium {
  font-weight: 500;
}

.text-normal {
    font-weight: 400;
}

.text-light {
  font-weight: 300;
}

.text-extra-light {
  font-weight: 200;
}

.text-thin {
  font-weight: 100;
}

Pull request #18440

@tarkhov tarkhov changed the title Text weights classes Add text weights classes Dec 5, 2015
@cvrebert cvrebert changed the title Add text weights classes Add font-weight utility classes Dec 5, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Dec 6, 2015

CC: @mdo for a decision on the desirability of such classes

@tarkhov
Copy link
Author

tarkhov commented Dec 6, 2015

Thank you.

@mdo
Copy link
Member

mdo commented Dec 6, 2015

I don't see a huge need for most of these. The only two I'd consider on the weight side is normal and bold as those apply rather universally to default web fonts.

@mdo mdo added this to the v4.0.0-alpha.2 milestone Dec 7, 2015
mdo added a commit that referenced this issue Dec 7, 2015
@mdo
Copy link
Member

mdo commented Dec 7, 2015

Added the ones I mentioned in 26da610.

@mdo mdo closed this as completed Dec 7, 2015
cvrebert added a commit that referenced this issue Dec 7, 2015
* `.font-normal` is too generic. Rename it to `.font-weight-normal` for clarity.
* Rename `.font-bold` to `.font-weight-bold` so as to parallel `.font-weight-normal`.
* In docs, gloss "weight" term in relation to fonts for the benefit of non-typographiles.

Refs #18433

[skip sauce]
cvrebert added a commit that referenced this issue Dec 7, 2015
* `.font-normal` is too generic. Rename it to `.font-weight-normal` for clarity.
* Rename `.font-bold` to `.font-weight-bold` so as to parallel `.font-weight-normal`.
* In docs, gloss "weight" term in relation to fonts for the benefit of non-typographiles.

Refs #18433

[skip sauce]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants