Tweak naming and docs of font utility classes #18452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvrebert
force-pushed
the
font-weight-utils
branch
from
968282e to
b115b5e
Compare
|
Damn thanks. Normal text is an actual weight though, and the choices beyond these classes is not binary. You can have semibold, for example. Maybe leave it as normal in the docs since that's the accepted CSS value? |
@mdo So you mean something like: <p class="font-weight-normal">Normal weight text.</p>? |
|
Yup! |
* `.font-normal` is too generic. Rename it to `.font-weight-normal` for clarity. * Rename `.font-bold` to `.font-weight-bold` so as to parallel `.font-weight-normal`. * In docs, gloss "weight" term in relation to fonts for the benefit of non-typographiles. Refs #18433 [skip sauce]
cvrebert
force-pushed
the
font-weight-utils
branch
from
b115b5e to
d1a0af8
Compare
|
Changed. |
cvrebert
added a commit
that referenced
this pull request
Dec 7, 2015
Tweak naming and docs of font utility classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.font-normalis way too generic (What does it make normal? There are many possibilities.). Rename it to.font-weight-normalfor clarity..font-boldto.font-weight-boldso as to parallel.font-weight-normal. I admit this rename is more debatable.Refs #18433.