Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .font-weight-bold to logical state name (.font-weight-strong) #21355

Closed
klasjersevi opened this issue Dec 16, 2016 · 1 comment
Closed
Labels

Comments

@klasjersevi
Copy link

klasjersevi commented Dec 16, 2016

The variable names introduced in #18433 and 968282e for strong text are based on the physical state name bold instead of the logical state name strong. This leads to confusion when you want to change/override these styles with custom styling.

Let's say you want to change the .font-weight-bold style to font-weight: 500; // Medium and then use font-weight: bold; in styles somewhere else, then the names gets confusing.

The names should be changed to match the <strong> element used in html.
Discussions about strong vs bold can be read at MDN - <strong>.

Similar renaming might also be applicable for .font-italic, but thats more open for discussion, since it has another meaning. More to read at MDN - <em>

So I propose renaming to the following:
.font-weight-strong { font-weight: bold; }

@cvrebert cvrebert changed the title Change font-weight-bold to logical state name (strong) Rename .font-weight-bold to logical state name (.font-weight-strong) Dec 19, 2016
@mdo
Copy link
Member

mdo commented Dec 20, 2016

I'm not super concerned about the naming of these utilities. If there's enough feedback around it into v4 once it's stable I can add aliases. Until then, no planned changes. Thanks though!

@mdo mdo closed this as completed Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants