Use numerical values for font-weight instead of keyword values #18613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really feel like this is a more consistent way to layout font-weights. It's been an issue of mine for a little while now. I understand why it was done originally as browsers were not consistent with weight numbers but there seems to be more weight numbering in v4 anyway. I actually originally noticed this in v4. So I can create a pull request for v4 as well. Just let me know. |
cvrebert
changed the title
cvrebert
changed the title
|
Not going to be changing this kind of stuff in v3 at this point—not an important change for this version. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request in regards to Issue #18605
I replaced all the
font-weight: bold;declaration withfont-weight: 700;as this allows for a much easier and more consistent flow for font-weight's throughout bootstrap.font-weight:with a700;value on the chosensans-serif,serifandmonospacetypefaces used in bootstrap is now supported by modern browsers.