Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching out bold descriptive value weights with numerical 700 values #18605

Closed
guylepage3 opened this issue Dec 19, 2015 · 4 comments
Closed
Labels

Comments

@guylepage3
Copy link

What’s the reasoning for all the use of the bold !default;keyword value throughout _variables.scss/variables.less?
$label-font-weight: bold !default;

Shouldn’t this be a numerical weight value for consistency? like weight: 700;?

Maybe i’m nuts, but this would allow for easier overrides of an h1 css selector's weight for example.

@guylepage3
Copy link
Author

I'll create a pull request for this in a little bit.

@guylepage3 guylepage3 reopened this Dec 20, 2015
@guylepage3 guylepage3 changed the title Switching out bold weights with 500 Switching out bold descriptive value weights with numerical 700 values Dec 20, 2015
@mdo
Copy link
Member

mdo commented Dec 30, 2015

What's the consistency issue?

@guylepage3
Copy link
Author

having a descriptive value font-weight ie. "bold" as opposed to a numerical value ie. "700". By switching the weight value to be a numerical value from bold, it allows for an easier overwrite down the line. All browsers that bootstrap supports now recognize the numerical value 700.

@mdo
Copy link
Member

mdo commented Jan 6, 2016

Sorry, but I don't see much of an improvement to customization here from using numbers over keywords. Sure browsers support them, but that's irrelevant to the most common approaches to styling text—"make it bold", "italicize that", etc. Until you get into custom web fonts, the specific numerical values don't have a huge impact on folks using and customizing Bootstrap (and then that's a whole other problem).

Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants