Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a variable for the default font-weights #20741

Closed
sbaechler opened this issue Sep 18, 2016 · 1 comment
Closed

Use a variable for the default font-weights #20741

sbaechler opened this issue Sep 18, 2016 · 1 comment

Comments

@sbaechler
Copy link
Contributor

Right now Bootstrap uses the hardcoded font weights bold and normal.

Websites might use different weights such as medium or thin or use light as default weight instead of normal.

If Bootstrap used settings variables for $font-weight-normal and $font-weight-bold the user could easily override the default values or use numerical weights.

This would also help #18605.

Those two lines could be added to the _variables.scss:

$font-weight-normal: normal;
$font-weight-bold: bold;

All occurrences of font-weight: normal; would be replaced by font-weight: $font-weight-normal. The same applied for font-weight: bold;.

Foundation uses a similar approach.

I could create a pull-request for this.

@cvrebert
Copy link
Collaborator

X-Ref: #16170

@mdo mdo added this to the v4.0.0-alpha.6 milestone Oct 9, 2016
twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this issue Oct 26, 2016
Use a variable for the default font weights. Fixes twbs#20741
@mdo mdo closed this as completed in 8402d23 Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants