Require JDK 23 to run Trino #23783
Merged
Require JDK 23 to run Trino #23783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/jdk23-requirement
branch
from
9f39b17 to
12ae7ed
Compare
|
Haha .. yeah .. I saw already @wendigo .. personally I think we should get it merged soon .. maybe even for 462 .. since officially 22 is EOL (from Oracle anyway.. and whatever that means really) |
|
The JDK 23.0.1 is due today @mosabua so once it's out, I'll update to it and we can consider merging it |
|
I will consider approving it then.. hahaha @wendigo |
|
@mosabua https://jdk.java.net/23/release-notes here you go :) |
wendigo
force-pushed
the
serafin/jdk23-requirement
branch
from
12ae7ed to
2820b4a
Compare
mosabua
reviewed
Oct 19, 2024
martint
approved these changes
Oct 19, 2024
mosabua
reviewed
Oct 19, 2024
wendigo
force-pushed
the
serafin/jdk23-requirement
branch
from
2820b4a to
0d8d260
Compare
|
@martint ASM in the compiler needs to be updated since we've added module-info.java to the SPI |
|
|
wendigo
force-pushed
the
serafin/jdk23-requirement
branch
2 times, most recently
from
ce2e399 to
43c8f13
Compare
wendigo
force-pushed
the
serafin/jdk23-requirement
branch
from
43c8f13 to
c51db6c
Compare
martint
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21316
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: