Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and require Java 23 #486

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Use and require Java 23 #486

merged 1 commit into from
Oct 24, 2024

Conversation

oneonestar
Copy link
Member

@oneonestar oneonestar commented Sep 26, 2024

Description

Use and require Java 23.

Release notes

(x) Release notes are required, with the following suggested text:

* Require Java 23 for build and runtime.

@cla-bot cla-bot bot added the cla-signed label Sep 26, 2024
@oneonestar oneonestar changed the title (For test) Use and require Java 23 Use and require Java 23 Oct 17, 2024
@willmostly
Copy link
Contributor

@oneonestar is this ready to review?

@mosabua
Copy link
Member

mosabua commented Oct 18, 2024

I think this might also need an upgrade of airlift and airbase -- please check with @wendigo

@mosabua
Copy link
Member

mosabua commented Oct 18, 2024

Also .. we probably want a separate PR in parallel that runs with 24-ea similar to how we run it in Trino

@oneonestar
Copy link
Member Author

oneonestar commented Oct 21, 2024

is this ready to review?

@willmostly Yea.

I think this might also need an upgrade of airlift and airbase -- please check with @wendigo

Sure #529

Also .. we probably want a separate PR in parallel that runs with 24-ea similar to how we run it in Trino

#530

Since Java 22 is already EOL, we should roll this out soon.

Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oneonestar
Copy link
Member Author

Let's ship it together with Trino. 🚀
trinodb/trino#23783

@oneonestar oneonestar merged commit fd418e6 into trinodb:main Oct 24, 2024
2 checks passed
@oneonestar oneonestar deleted the star/java_23 branch October 24, 2024 01:04
@github-actions github-actions bot added this to the 12 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants