-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Trino dependencies to 464 #534
Update Trino dependencies to 464 #534
Conversation
Trino released 463 (not 464) yesterday. |
Please reopen after Trino released 464. |
I am just reopening and setting it to draft so others are aware of this effort. |
Please also upgrade in the TrinoGatewayRunner class and see what we have in use in the quickstart and other docs. |
Any concerns with reopening @ebyhr ? |
There is no benefit to keep opening a PR which cannot build. |
The benefit is that others can see that it exists and dont try to do the same work .. I nearly did exactly that. And a build failure is no big deal in this case in my opinion. |
What is the motivation sending a PR which upgrades to the version which doesn't exist? |
Opening now to see how CI goes. Trino 464 is out. We can also update the Runner but that can be a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ..
Description
Trino 464 requiring Java 23 is merged yesterday, but not released yet.
We can merge PR when they release it.
Additional context and related issues
#486
trinodb/trino#23783
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: