Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trino dependencies to 464 #534

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Oct 24, 2024

Description

Trino 464 requiring Java 23 is merged yesterday, but not released yet.
We can merge PR when they release it.

Additional context and related issues

#486
trinodb/trino#23783

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

@Chaho12 Chaho12 requested a review from oneonestar October 24, 2024 14:31
@cla-bot cla-bot bot added the cla-signed label Oct 24, 2024
@ebyhr
Copy link
Member

ebyhr commented Oct 25, 2024

Trino released 463 (not 464) yesterday.

@ebyhr ebyhr closed this Oct 25, 2024
@ebyhr
Copy link
Member

ebyhr commented Oct 25, 2024

Please reopen after Trino released 464.

@mosabua mosabua reopened this Oct 26, 2024
@mosabua mosabua marked this pull request as draft October 26, 2024 00:03
@mosabua
Copy link
Member

mosabua commented Oct 26, 2024

I am just reopening and setting it to draft so others are aware of this effort.

@mosabua
Copy link
Member

mosabua commented Oct 26, 2024

Please also upgrade in the TrinoGatewayRunner class and see what we have in use in the quickstart and other docs.

@mosabua
Copy link
Member

mosabua commented Oct 26, 2024

Any concerns with reopening @ebyhr ?

@ebyhr
Copy link
Member

ebyhr commented Oct 26, 2024

There is no benefit to keep opening a PR which cannot build.

@mosabua
Copy link
Member

mosabua commented Oct 26, 2024

There is no benefit to keep opening a PR which cannot build.

The benefit is that others can see that it exists and dont try to do the same work .. I nearly did exactly that. And a build failure is no big deal in this case in my opinion.

@ebyhr ebyhr closed this Oct 26, 2024
@ebyhr
Copy link
Member

ebyhr commented Oct 26, 2024

What is the motivation sending a PR which upgrades to the version which doesn't exist?

@mosabua
Copy link
Member

mosabua commented Oct 31, 2024

Opening now to see how CI goes. Trino 464 is out. We can also update the Runner but that can be a separate PR.

@mosabua mosabua reopened this Oct 31, 2024
@mosabua mosabua marked this pull request as ready for review October 31, 2024 20:36
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ..

@mosabua mosabua merged commit 5e2c203 into trinodb:main Oct 31, 2024
2 of 4 checks passed
@github-actions github-actions bot added this to the 12 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants