Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and require Java 23 #21316

Closed
6 of 8 tasks
wendigo opened this issue Mar 28, 2024 · 6 comments · Fixed by #23783
Closed
6 of 8 tasks

Use and require Java 23 #21316

wendigo opened this issue Mar 28, 2024 · 6 comments · Fixed by #23783
Assignees
Labels
roadmap Top level issues for major efforts in the project

Comments

@wendigo
Copy link
Contributor

wendigo commented Mar 28, 2024

This issues aims to detail and track the progress towards adopting Java 23 as build and runtime requirement for Trino.

Background and motivation

Trino completely adopted Java 22 as of Trino 44x. See https://trino.io/blog/2024/03/13/java-22 and https://trino.io/docs/current/release/release-44x.html. Java 22 is an STS release of Java.

Java 23 is a STS Java release and scheduled to ship in September 2024 (https://mail.openjdk.org/pipermail/jdk-dev/2024-March/008832.html) Adoption timing in Trino will depend on testing results and feedback, as well as the time for implementation and collaboration with Trino community members.

Specifically, for Java 23, these are some features that we want to be able to leverage:

  • No new features are targeting JDK 23 yet

Proposed schedule for JDK 23 release is:

  • 2024/06/06 Rampdown Phase One
  • 2024/07/18 Rampdown Phase Two
  • 2024/08/08 Initial Release Candidate
  • 2024/08/22 Final Release Candidate
  • 2024/09/17 General Availability

The plan is to test and ensure runtime and compile JDK 23 compatibility before GA.

Implementation

Following steps are roughly in order:

  • CI build with Java 23 EA in parallel to Java 22
  • Blog post about plan to adopt Java 23, @mosabua
  • Update dependencies as required to support Java 23, @wendigo
  • Update JVM in docker container to Java 23, @wendigo
  • Wait for official release of Java 23 and Eclipse Temurin binaries (if necessary in terms of timing)
  • Ship a release with the updated container image
  • Update build, docs, and runtime to require Java 23
  • Ship a release with new requirement, announce and update blog post
@mosabua
Copy link
Member

mosabua commented Mar 29, 2024

Nice @wendigo !

@wendigo
Copy link
Contributor Author

wendigo commented Jul 4, 2024

JDK 23 is ready: #21732

@mosabua
Copy link
Member

mosabua commented Sep 13, 2024

Do we want some announcement besides release notes. I think timing will be in one of the next releases after 458. GA for 23 is 17th of Sept.

@mosabua
Copy link
Member

mosabua commented Sep 13, 2024

I will prepare a blog post for next week

@mosabua
Copy link
Member

mosabua commented Sep 18, 2024

Blog post published and announced on slack, linkedin and reddit r/java. https://trino.io/blog/2024/09/17/java-23

@wendigo
Copy link
Contributor Author

wendigo commented Sep 19, 2024

Next one: #23498

@mosabua mosabua added the roadmap Top level issues for major efforts in the project label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Top level issues for major efforts in the project
Development

Successfully merging a pull request may close this issue.

2 participants