Fix test-other-modules failure due to lack of Redshift secrets #16484
Conversation
ebyhr
added
the
no-release-notes
| @@ -173,6 +173,30 @@ | |||
| </dependencies> | |||
|
|
|||
| <profiles> | |||
| <profile> | |||
| <id>default</id> | |||
There was a problem hiding this comment.
The other option would be to add in ci.yml
!:trino-redshift,
after
trino/.github/workflows/ci.yml
Line 447 in 11942a4
I'm inclined however to use rather the current option because it gives us extra test-coverage for non cloud-tests that are executed this way on trino-redshift.
|
Why would |
|
|
|
but it should, shouldn't it? |
|
Added another commit to separate a job. |
| @@ -538,6 +539,7 @@ jobs: | |||
| - { modules: plugin/trino-postgresql } | |||
| - { modules: plugin/trino-raptor-legacy } | |||
| - { modules: plugin/trino-redis } | |||
| - { modules: plugin/trino-redshift } | |||
There was a problem hiding this comment.
this will fail.
we should have only { modules: plugin/trino-redshift, profile: cloud-tests }
let's add some comment
There was a problem hiding this comment.
It works as the screenshot is showing:
findepi
changed the title
findepi
changed the title
Fix CI failure on master https://github.com/trinodb/trino/actions/runs/4374451893/jobs/7653896692