Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-other-modules failure due to lack of Redshift secrets #16484

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Fix test-other-modules failure due to lack of Redshift secrets #16484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b41fe6
Exclude Reshift tests by default
ebyhr Mar 10, 2023
2e4cd28
Separate CI job for Redshift connector
ebyhr Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ jobs:
!:trino-postgresql,
!:trino-raptor-legacy,
!:trino-redis,
!:trino-redshift,
!:trino-singlestore,
!:trino-sqlserver,
!:trino-test-jdbc-compatibility-old-server,
Expand Down Expand Up @@ -538,6 +539,7 @@ jobs:
- { modules: plugin/trino-postgresql }
- { modules: plugin/trino-raptor-legacy }
- { modules: plugin/trino-redis }
- { modules: plugin/trino-redshift }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail.
we should have only { modules: plugin/trino-redshift, profile: cloud-tests }

let's add some comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as the screenshot is showing:
Screenshot 2023-03-10 at 23 46 17

- { modules: plugin/trino-redshift, profile: cloud-tests }
- { modules: plugin/trino-singlestore }
- { modules: plugin/trino-sqlserver }
Expand Down
24 changes: 24 additions & 0 deletions plugin/trino-redshift/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,30 @@
</dependencies>

<profiles>
<profile>
<id>default</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option would be to add in ci.yml

!:trino-redshift,

after

trino/.github/workflows/ci.yml

Line 447 in 11942a4

!:trino-redis,

I'm inclined however to use rather the current option because it gives us extra test-coverage for non cloud-tests that are executed this way on trino-redshift.

<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
<exclude>**/TestRedshiftAutomaticJoinPushdown.java</exclude>
<exclude>**/TestRedshiftConnectorTest.java</exclude>
<exclude>**/TestRedshiftConnectorSmokeTest.java</exclude>
<exclude>**/TestRedshiftTableStatisticsReader.java</exclude>
<exclude>**/TestRedshiftTypeMapping.java</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>cloud-tests</id>
<activation>
Expand Down