Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump redshift-jdbc42 to 2.1.0.12 #16022

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

findinpath
Copy link
Contributor

Description

Changelog

https://github.com/aws/amazon-redshift-jdbc-driver/blob/master/CHANGELOG.md#v21011-2023-02-03

This new version of the JDBC AWS Redshift driver includes relevant bug fixes for Trino specific scenarios:

Thank you @ssheikin for your contribution.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Feb 8, 2023
@findinpath
Copy link
Contributor Author

This should be merged after #15817 lands.

@findinpath findinpath added the no-release-notes This pull request does not require release notes entry label Feb 8, 2023
@ssheikin
Copy link
Contributor

ssheikin commented Feb 8, 2023

@findinpath lgtm. Please test that above issues are resolved.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Mar 1, 2023
@mosabua
Copy link
Member

mosabua commented Mar 2, 2023

Looks like this might be good for merge even though the linked PR for the CI update is closed.

@github-actions github-actions bot removed the stale label Mar 2, 2023
@ssheikin
Copy link
Contributor

ssheikin commented Mar 3, 2023

I'd also prefer to add tests within this pr, which will ensure that issues mentioned in the description are resolved.

@findinpath findinpath changed the title Bump redshift-jdbc42 to 2.1.0.11 Bump redshift-jdbc42 to 2.1.0.12 Mar 7, 2023
@findinpath findinpath force-pushed the findinpath/bump-redshift-jdbc42 branch from c4fcd77 to 660f834 Compare March 7, 2023 10:31
@findinpath findinpath force-pushed the findinpath/bump-redshift-jdbc42 branch from 660f834 to 1e2c88a Compare March 9, 2023 13:15
@kokosing
Copy link
Member

kokosing commented Mar 9, 2023

/test-with-secrets sha=1e2c88a4e9908965777020c02a7556684f3fd423

@findinpath
Copy link
Contributor Author

CI hit #16484

@findinpath findinpath force-pushed the findinpath/bump-redshift-jdbc42 branch from 1e2c88a to 3e4dbbc Compare March 13, 2023 05:50
@ebyhr ebyhr merged commit d1c9158 into trinodb:master Mar 13, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

6 participants