-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose rule stats in QueryStats #16365
Conversation
core/trino-main/src/main/java/io/trino/execution/querystats/QueryRuleStats.java
Outdated
Show resolved
Hide resolved
5f0ecc9
to
aba4078
Compare
b55f35f
to
33176e1
Compare
Failure due #16383 |
core/trino-main/src/main/java/io/trino/execution/querystats/QueryStatsCollector.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/iterative/IterativeOptimizer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/QueryRuleStats.java
Outdated
Show resolved
Hide resolved
ebc5d2c
to
ddaab70
Compare
Failed due #16406 |
core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/QueryStateMachine.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/CoordinatorModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/DefaultQueryStatsCollector.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/QueryRuleStats.java
Outdated
Show resolved
Hide resolved
411f3b4
to
e08c90c
Compare
Are the rules ordered by total time? |
Yes, rules are ordered by |
32c82aa
to
bf062f3
Compare
core/trino-spi/src/main/java/io/trino/spi/eventlistener/QueryPlanOptimizerStatistics.java
Outdated
Show resolved
Hide resolved
c093910
to
0278cfa
Compare
core/trino-spi/src/main/java/io/trino/spi/eventlistener/QueryPlanOptimizerStatistics.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/PlanOptimizersStatsCollector.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/PlanOptimizersStatsCollector.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/PlanOptimizersStatsCollector.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/PlanOptimizersStatsCollector.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/querystats/QueryPlanOptimizerStats.java
Outdated
Show resolved
Hide resolved
a5f32a4
to
f72f91f
Compare
core/trino-main/src/main/java/io/trino/execution/querystats/PlanOptimizersStatsCollector.java
Outdated
Show resolved
Hide resolved
a07fc2d
to
6d825a0
Compare
Expose optimizer rule statistics per query in QueryInfo JSON. The number of rules exposed could be adjusted using the `query.reported-rule-stats-limit` configuration parameter.
Because this includes a new configuration property, it needs documentation. Would you be able to do a follow-up PR for that, or would you prefer that I handle it? cc @martint |
cc @Dith3r ^^ |
In one of the patchsets I've removed documentation as we agreed that this is very internal thing (query JSON is only affected). If we want to add documentation, I can create new PR for it - please only confirm if this is needed. |
follow-up -- #16960 |
Description
Fixes #2578.
Expose optimizer rule statistics per query in QueryInfo JSON. The number of rules exposed could be adjusted using the
query.reported-rule-stats-limit
configuration parameter.Example output:
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: