Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

[vtctld do not merge] Custom build for vtctld development (cherry-picks on top of 9.0) #204

Closed
wants to merge 15 commits into from

Conversation

ajm188
Copy link

@ajm188 ajm188 commented Apr 6, 2021

This contains the vtctld patches backported onto our in-progress deploy branch. The following PR's were challenging due to many conflicts (@ajm188 , if you could audit them, that would be great):

rohit-nayak-ps and others added 8 commits April 5, 2021 19:47
[vtctld] Migrate cell getters

Signed-off-by: Andrew Mason <[email protected]>
[vtctld] migrate tablet getters

Signed-off-by: Andrew Mason <[email protected]>
…nd_pkg

[vtctld] vtctldclient command pkg

Signed-off-by: Andrew Mason <[email protected]>
[vtctld] Add GetSrvVSchema command

Signed-off-by: Andrew Mason <[email protected]>
[vtctld] Migrate GetSchema

Signed-off-by: Andrew Mason <[email protected]>
[vtctld] Migrate ListBackups as GetBackups in new vtctld server

Signed-off-by: Andrew Mason <[email protected]>
[vtctld] Migrate GetVSchema to VtctldServer

Signed-off-by: Andrew Mason <[email protected]>
[vtctld] Migrate topo management RPCs

Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 requested review from rafael and setassociative April 6, 2021 15:58
@ajm188 ajm188 requested a review from doeg as a code owner April 6, 2021 15:58
deepthi and others added 7 commits April 6, 2021 09:31
…ce_errors

[vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
[vtctld | tests only] testtmclient refactor

Note: Manually deleted api_test.go due to cherry-pick conflict

Signed-off-by: Rafael Chacon <[email protected]>
Provide named function for squashing usage errors; start using it

Signed-off-by: Rafael Chacon <[email protected]>
Note (@rafael): This one required a bunch of manual intervention
[vtctld] Add v0 GetWorkflows rpc and workflow/vexec packages

Signed-off-by: Rafael Chacon <[email protected]>
[vtctld] Migrate GetSrvKeyspace as GetSrvKeyspaces in VtctldServer

Signed-off-by: Rafael Chacon <[email protected]>
…cation_positions

[vtctld] Migrate ShardReplicationPositions

Signed-off-by: Rafael Chacon <[email protected]>
[vtctl|vtctldserver] List/Get Tablets timeouts

Signed-off-by: Rafael Chacon <[email protected]>
@rafael rafael changed the title slack 9 vtctld wip [vtctld] Custom build for vtctld development (cherry-picks on top of 9.0) Apr 6, 2021
@rafael rafael changed the title [vtctld] Custom build for vtctld development (cherry-picks on top of 9.0) [vtctld do not merge] Custom build for vtctld development (cherry-picks on top of 9.0) Apr 6, 2021
Copy link
Author

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vtctld changes all look good to me. github won't let me approve my own PR, which, fair

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants