Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtctld] vtctldclient command pkg #7321

Merged
merged 8 commits into from
Jan 20, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jan 19, 2021

Description

This moves the command definitions and logic to a subpackage, to allow us to more easily break up commands into files logically, rather than shoving everything into a single "commands" file.

For testing, I validated I could still compile and run an rpc, which to me is enough confirmation this is a no-op.

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required No
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

We're going to need this out of main in just a bit

Signed-off-by: Andrew Mason <[email protected]>
- write docs
- copy over Root and its related variables
- copy over cell commands

Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 requested review from doeg and rohit-nayak-ps January 19, 2021 16:08
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice and tidy! ✨

*/

/*
Package command contains the commands used by vtctldclient. It is intended only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously, these docs are so so good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+100

@deepthi deepthi merged commit 99cd872 into vitessio:master Jan 20, 2021
@askdba askdba added this to the v9.0 milestone Jan 25, 2021
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Feb 11, 2021
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Mar 11, 2021
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Apr 6, 2021
…nd_pkg

[vtctld] vtctldclient command pkg

Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 deleted the am_vtctldclient_command_pkg branch May 29, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants