Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtctld] Migrate cell getters #7302

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jan 15, 2021

Description

This migrates the following vtctl commands:

  • GetCellInfoNames
  • GetCellInfo
  • GetCellsAliases

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

- Add MarshalJSON helper (similar, but not exactly what's in
  go/vt/vtctl/vtctl.go).
- Refactor other commands to use MarshalJSON, where appropriate.
- Add cell getter commands.

Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 requested review from doeg and sougou as code owners January 15, 2021 17:21
@ajm188 ajm188 requested a review from rohit-nayak-ps January 15, 2021 17:21
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to meeee

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 147d196 into vitessio:master Jan 15, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Feb 11, 2021
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Mar 11, 2021
rafael pushed a commit to tinyspeck/vitess that referenced this pull request Apr 5, 2021
[vtctld] Migrate cell getters

Signed-off-by: Rafael Chacon <[email protected]>
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Apr 6, 2021
[vtctld] Migrate cell getters

Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 deleted the am_vtctld_cell_getters branch May 29, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants