-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctld] Migrate cell getters #7302
Merged
rohit-nayak-ps
merged 3 commits into
vitessio:master
from
tinyspeck:am_vtctld_cell_getters
Jan 15, 2021
Merged
[vtctld] Migrate cell getters #7302
rohit-nayak-ps
merged 3 commits into
vitessio:master
from
tinyspeck:am_vtctld_cell_getters
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stubs Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
- Add MarshalJSON helper (similar, but not exactly what's in go/vt/vtctl/vtctl.go). - Refactor other commands to use MarshalJSON, where appropriate. - Add cell getter commands. Signed-off-by: Andrew Mason <[email protected]>
doeg
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to meeee
rohit-nayak-ps
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Feb 11, 2021
[vtctld] Migrate cell getters
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
[vtctld] Migrate cell getters
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 5, 2021
[vtctld] Migrate cell getters Signed-off-by: Rafael Chacon <[email protected]>
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
[vtctld] Migrate cell getters Signed-off-by: Andrew Mason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This migrates the following vtctl commands:
GetCellInfoNames
GetCellInfo
GetCellsAliases
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: