[vtctld] Migrate ShardReplicationPositions #7690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
This also copies over `SortReplicatingTablets` over from legacy vtctl Signed-off-by: Andrew Mason <[email protected]>
…w impl The new implementation contains the bugfix for getting partial results with one (or more) dead/unreachable tablets. Closes vitessio#4073. Signed-off-by: Andrew Mason <[email protected]>
doeg
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Looks great as always and TIL a little more about go contexts. :)
This seems straightforward to me, but totally up to you if you want to wait for a Vitess-y blessing (a Vitessing?!) from @deepthi / @setassociative.
deepthi
reviewed
Mar 17, 2021
go/cmd/vtctldclient/cli/shards.go
Outdated
Comment on lines
52
to
55
| type ReplicatingTablet struct { | ||
| Status *replicationdatapb.Status | ||
| Tablet *topodatapb.Tablet | ||
| } |
There was a problem hiding this comment.
Did you consider writing it like this?
type ReplicatingTablet struct {
topodatapb.Tablet
Status *replicationdatapb.Status
}
There was a problem hiding this comment.
I did, and decided not to for a silly reason. Basically I was worried "what if Tablet and Status each have a field with the same name, you wouldn't be able to tell the difference" but now I remember that Go will just force you to disambiguate so it's actually not a problem at all.
I'll make this change!
go/cmd/vtctldclient/cli/shards.go
Outdated
| // 1. Tablets that do not have a replication Status. | ||
| // 2. Any tablets of type MASTER. | ||
| // 3. Remaining tablets sorted by comparing replication positions. | ||
| func SortReplicatingTablets(tabletMap map[string]*topodatapb.Tablet, replicationStatuses map[string]*replicationdatapb.Status) []*ReplicatingTablet { |
| // The RPC was not timed out or canceled. We treat this | ||
| // as a fatal error for the overall request. | ||
| rec.RecordError(fmt.Errorf("MasterPosition(%s) failed: %w", alias, err)) | ||
|
|
| // The RPC was not timed out or canceled. We treat this | ||
| // as a fatal error for the overall request. | ||
| rec.RecordError(fmt.Errorf("ReplicationStatus(%s) failed: %s", alias, err)) | ||
|
|
ajm188
force-pushed
the
am_vtctld_shard_replication_positions
branch
from
502bf7f to
502f0c1
Compare
Signed-off-by: Andrew Mason <[email protected]>
ajm188
force-pushed
the
am_vtctld_shard_replication_positions
branch
from
502f0c1 to
6e0edb6
Compare
8 tasks
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
…cation_positions [vtctld] Migrate ShardReplicationPositions Signed-off-by: Rafael Chacon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
ShardReplicationPositionsvtctl command to aVtctldServerrpcVtctldServerimplementation, to fix the timeout bug in the old server as well as the new.Related Issue(s)
vtctl ShardReplicationPositionsis called (can lead to indefinite hang) #4073Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: