This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Slack vitess 2020.04.28.r0 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protoc generated code was not matching the goimports standard. I've added a goimports step after the build. This caused another breakage because time.proto did not match its package name of vttime. I've fixed that also. Signed-off-by: Sugu Sougoumarane <[email protected]>
build: temporary unbreak for make proto
Fixes vitessio#5636 There was an unnecessary error check in a goroutine that could terminate late. The check has been removed. Signed-off-by: Sugu Sougoumarane <[email protected]>
tests: fix panic in vstreamer_test
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Move flaky tests to _flaky_ + change unit/unit_race to go 1.13
The latest stream from "current" position feature introduced a hang in the vstreamer, if the subsequent DMLs started getting played before the vstreamer would start pulling from binlogs. The fix is to wait till we get a heartbeat before proceeding with the tests. Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Ajeet jain <[email protected]>
Signed-off-by: Ajeet jain <[email protected]>
Signed-off-by: RickyRajinder <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Ajeet jain <[email protected]>
Signed-off-by: Ajeet jain <[email protected]>
vrepl: yet another vstreamer deflake
increased timeout of tablet status check
Add execute as root check to mysqlctl
…or the old vtctld webapp
Embed vtctld assets
Signed-off-by: Gary Edgar <[email protected]>
…er flag Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Fixes vitessio#5590 Previously the nextval code assumed that next_id will be changed externally. As explained in the bug, this can now happen with the new use cases. This change ensures that vttablet will work correctly even if next_id was changed. Signed-off-by: Sugu Sougoumarane <[email protected]>
tools/make-release-packages.sh: stop packaging web dir
Signed-off-by: Ajeet jain <[email protected]>
Default testsuite to RBR
Tabletmanager tests cases migrated from Python
Signed-off-by: Ajeet jain <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Deprecate disable_local_gateway flag.
…-patch Add web_dir options back so as to not break existing binaries. Options are ignored
Fix relay-log and relay-log-index paths
Signed-off-by: Morgan Tocker <[email protected]>
Add percona 56 new dependency
Fixes vitessio#5752 DBClient was setting the connection to nil after close, which was causing vreplication to panic because it defers a Rollback on all connections. The safer thing is to close the connection, but not set it to nil. There's no test for DBClient, but I've manually verified that this won't panic any more. Signed-off-by: Sugu Sougoumarane <[email protected]>
A file close was done before error checking, and the TestValidParallel name collided with TestValid when typing in `go test -run TestValid`. Signed-off-by: Jeff Hodges <[email protected]>
make sqlparser/parse_test.go nicer to work with
add DISTINCTROW to regular function without calling special token
This addresses symptoms, but not causes, discussed in vitessio#5755 and vitessio#5756 Signed-off-by: Jeff Hodges <[email protected]>
Fix vreplication panic
correct gofmt of vtctld and re-sync go.mod
…sio#5738) * first commit to use zk in tests Signed-off-by: Ajeet jain <[email protected]> * Fixed zookeeper and added consul Signed-off-by: Ajeet jain <[email protected]> * added consul setup Signed-off-by: Ajeet jain <[email protected]> * added consul and zk2 tabletmanager tests in config Signed-off-by: Ajeet jain <[email protected]> * Minor edits Signed-off-by: Ajeet jain <[email protected]> * fixing verticalsplit test Signed-off-by: Ajeet jain <[email protected]> * Moving tabletmanager test to shard 18 Signed-off-by: Ajeet jain <[email protected]> * fixed reparent test Signed-off-by: Ajeet jain <[email protected]> * Removing unrequired changes Signed-off-by: Ajeet jain <[email protected]> * review comments addressed Signed-off-by: Ajeet jain <[email protected]>
…itessio#5693) * initial commit for backup_only Signed-off-by: Ajeet jain <[email protected]> * changes in package structure Signed-off-by: Ajeet jain <[email protected]> * updating package name and fixing a test Signed-off-by: Ajeet jain <[email protected]> * removed unrequired teardown code Signed-off-by: Ajeet jain <[email protected]> * Removed debug code Signed-off-by: Ajeet jain <[email protected]> * Reset replication on mysql _before_ deleting vttablet from topo Signed-off-by: deepthi <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]>
) * initial commit for backup_only Signed-off-by: Ajeet jain <[email protected]> * changes in package structure Signed-off-by: Ajeet jain <[email protected]> * updating package name and fixing a test Signed-off-by: Ajeet jain <[email protected]> * removed unrequired teardown code Signed-off-by: Ajeet jain <[email protected]> * Removed debug code Signed-off-by: Ajeet jain <[email protected]> * inital commit for xtrabackup Signed-off-by: Ajeet jain <[email protected]> * fix sequencing of cleanup Signed-off-by: Ajeet jain <[email protected]> * fix terminate restore for xtrabackup Signed-off-by: Ajeet jain <[email protected]> * updated config for xtrabackup Signed-off-by: Ajeet jain <[email protected]> * added xtrabackup stream mode Signed-off-by: Ajeet jain <[email protected]> * updated config for xtrabackup stream Signed-off-by: Ajeet jain <[email protected]> * minor changes to config Signed-off-by: Ajeet jain <[email protected]> * Added percona 56 new dependency Signed-off-by: Ajeet jain <[email protected]> * Putting the dependency at right place Signed-off-by: Ajeet jain <[email protected]> * updated apt tp apt-get Signed-off-by: Ajeet jain <[email protected]> * corrected the typo Signed-off-by: Ajeet jain <[email protected]> * fixed a comma in config.json Signed-off-by: Ajeet jain <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: Kim Bao Long <[email protected]>
Fix some typos in comments
upgrade aws-sdk-go to 1.28.8
remove reference to web/vtctld from Makefile
Signed-off-by: Morgan Tocker <[email protected]>
…itess-2020.04.28.r0
Signed-off-by: Michael Demmer <[email protected]>
Patch to handle this case while we move towards a permanent fix upstream. cf. vitessio#4661 vitessio#4669
ajm188
force-pushed
the
slack-vitess-2020.04.28.r0
branch
from
5732eeb to
6ddeb92
Compare
zmagg
force-pushed
the
slack-vitess-2020.04.28.r0
branch
from
6ddeb92 to
fd11709
Compare
…ounts Update query counts for stream queries from vtgate
zmagg
force-pushed
the
slack-vitess-2020.04.28.r0
branch
from
fd11709 to
070a595
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in changes from upstream v5.20+20200204 plus the following changes:
a40c5e7 (Stream execute query logging vitessio/vitess#6056) Stream execute query logging924824b (Pass in cell to EnsureVSchema and GetOrCreateShard vitessio/vitess#5930) pass cell to EnsureVSchema and GetOrCreateShard04f66d3 (Adds supports to target DestinationKeyspaceID to handle other vitessio/vitess#6040) Adds supports to target DestinationKeyspaceID3519b08 (Adds Autocommit to V2 API vitessio/vitess#5909) Adds Autocommit to V2 API